refactor: better processing of summary chart data #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuccaBitfly
commented
May 26, 2025
Comment on lines
-852
to
-858
| containsGroups := false | ||
| requestedGroupsMap := make(map[int64]bool) | ||
| for _, groupId := range groupIds { | ||
| requestedGroupsMap[groupId] = true | ||
| if !containsGroups && groupId >= 0 { | ||
| containsGroups = true | ||
| } |
There was a problem hiding this comment.
note: containsGroups was unused, not sure what this was needed for
LuccaBitfly
commented
May 26, 2025
Comment on lines
+939
to
+943
| type key struct { | ||
| Timestamp uint64 | ||
| GroupId int64 | ||
| } | ||
| rowsMap := make(map[key]*t.VDBValidatorSummaryChartRow) |
There was a problem hiding this comment.
note: https://go.dev/blog/maps#key-types recommends to use key types instead of multidimensional maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.