STARSolo add --outBAMsortingBinsN an add a param to force samtools sort #7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think |
mvdbeek
reviewed
Jun 19, 2025
| @@ -584,4 +584,30 @@ | |||
| #end if | |||
| ]]></token> | |||
|
|
|||
| <xml name="perf_params"> | |||
There was a problem hiding this comment.
There's no way user will set reasonable values here. I would suggest calculating reasonable values for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to #7043
--outSAMtype. This patch should still keep the existing functionality of the tool. It adds an extra boolean paramuse_samtools_sortwhich forces--outSAMtype BAM Unsortedand usessamtools sortto sort the BAM file.--outBAMsortingBinsNand--winAnchorMultimapNmaxparams which already exist in STAR.