Skip to content

Update pretext to 0.0.5 with adapted test-data #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update pretext to 0.0.5 with adapted test-data #7050

wants to merge 3 commits into from

Conversation

SaimMomin12
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR updates pretext to version 0.0.5 and also includes updated test data.

Fixes: #7039

@bernt-matthias
Copy link
Contributor

Test data got large. Can we replace by content assertions? Or reduce size?

@SaimMomin12
Copy link
Contributor Author

The generated output file is a BMP and size is unfortunately not in our controls. I think we can use has_size assertions here, or?

@bernt-matthias
Copy link
Contributor

Yep, has_size and maybe the has_image_... assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernt-matthias bernt-matthias bernt-matthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaimMomin12 @bernt-matthias