Fix/0.17.0 deps and build main #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
force-pushed
the
fix/0.17.0-deps-and-build-main
branch
from
b8be4ea to
ab71220
Compare
BarisYazici
reviewed
Nov 20, 2025
|
|
||
| ## Dependencies | ||
| find_package(Poco REQUIRED COMPONENTS Net Foundation) | ||
| find_package(console_bridge REQUIRED) |
Contributor
There was a problem hiding this comment.
this should be a transitive dependency coming from Pinocchio library. So we don't need to add that here. We had this issue that libfranka couldn't find the console_bridge. Try to remove ros2 packages including the console_bridge that solves the issue e.g. ros_${distro}pinocchio or ros${distro}_console_bridge
AndreasKuhner
force-pushed
the
main
branch
3 times, most recently
from
a99d195 to
182c9c4
Compare
kmohyeldin
force-pushed
the
main
branch
3 times, most recently
from
0b3fa66 to
06bba4e
Compare
AndreasKuhner
force-pushed
the
main
branch
3 times, most recently
from
ad6f82d to
b909130
Compare
kmohyeldin
force-pushed
the
main
branch
2 times, most recently
from
6643c66 to
9dd8c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the compilation.