ci: re-add rust-cache #12156
Merged
ci: re-add rust-cache #12156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
0xrusowsky,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Notice the minor jobs on the left are a lot faster. This is because sccache is slower on average for small crates due to having to calculate a hash of all arguments, input/output files etc. and having to download the cached artifacts.
But it is more granular (per-compiler invocation instead of per-workspace), meaning we still have a lot of cache hits when the rust-cache action would recompile from scratch.
We still keep sccache since the GHA cache will likely be evicted often so we have a backup, and the rust-cache action does not cache the workspace by default.
See sccache debug logs here https://github.com/foundry-rs/foundry/actions/runs/18598664791/job/53031467273?pr=12154#step:8:1
I think by having both we get the best of both worlds.