Skip to content

content: Add Leo Rover v1.9 ROS API #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

bjsowa
Copy link
Member

@bjsowa bjsowa commented Jun 9, 2025

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2025

Deploying fictionlab-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2dbb96c
Status: ✅  Deploy successful!
Preview URL: https://c90eaad3.fictionlab-docs.pages.dev
Branch Preview URL: https://content-leo-1-9-software-spe.fictionlab-docs.pages.dev

View logs

@bjsowa bjsowa marked this pull request as ready for review June 10, 2025 07:34
@bjsowa bjsowa requested a review from Krzemien97 as a code owner June 10, 2025 07:34

- `cmd_vel` ([geometry_msgs/msg/Twist])

Target velocity of the Rover. Only linear.x $[\frac{m}{s}]$ and angular.z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should at least mention in some sort of :::info tag about mecannum wheels and y axis. Also in mecannum wheels tutorial there should be this info added.

Filtered readings from the onboard IMU. The filter does 2 things:

- Adds a dynamic bias to the gyroscope readings.
- Adds estimated orientation by fusing the accelerometer and gyroscope data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Adds estimated orientation by fusing the accelerometer and gyroscope data.
- Adds an estimated orientation by fusing the accelerometer and gyroscope data.


Apart from the aforementioned parameters, the camera node also translates the
libcamera controls into ROS parameters. The camera controls are documented in
[picamera2 documentation (Appendix C)].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there should be some comment or clarification that not every parameter in the camera controls is available in the API.


:::

#### /camera/debayer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the debayer and rectify nodes parameters I feel like there could be more parameters listed. Obviously we can ignore those generic ones like qos_overrides but maybe those like res_unit, xdpi ydpi png_level could be listed.


- `wheels/torque_constant` (type: `float`)

The torque in Nm produced by the wheel per 1 Ampere of windind current.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format units

Suggested change
The torque in Nm produced by the wheel per 1 Ampere of windind current.
The torque in $Nm$ produced by the wheel per 1 Ampere of windind current.

The quality of the JPEG compression for the rectified monochrome image. Range:
0-100.

#### /firmware
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mecanum_wheels param missing

set to `false`, the gyroscope readings will not be filtered and will be
published as is.

- `do_save_bias` (type: `bool`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's read-only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants