Skip to content

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Sep 8, 2025

πŸ—’οΈ Description

Adds flag --skip-cleanup to execute to disable getting the funds back from the accounts funded during the tests.

Requested by Kamil from the Nethermind team.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@marioevz marioevz requested a review from fselmo September 8, 2025 23:16
@marioevz marioevz added type:feat type: Feature scope:execute Scope: Changes to the execute command feature:benchmark labels Sep 8, 2025
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm to follow up with #2148 πŸ‘πŸΌ

@marioevz marioevz merged commit 5dc2e5d into main Sep 12, 2025
15 checks passed
@marioevz marioevz deleted the execute-cleanup-optional branch September 12, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:benchmark scope:execute Scope: Changes to the execute command type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants