-
Notifications
You must be signed in to change notification settings - Fork 170
feat(tests): add zero edge cases for modexp eip7883 gas cost tests #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc-ing @LouisTsai-Csie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Could you please help update the table below:
There is a script that might help: #1929 (comment)
17a07fc
to
41662bd
Compare
Thank you for your review. I have updated the table. The coverage framework in the table is very good. I just complemented it with some edge cases wrt implementation (spec coverage is excellent). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem from my side! Let's wait for final review and get merge. cc @spencer-tb
@bshastry I am currently working on some refactoring PR for eip7823 & eip7883, it will give you an overview of test coverage like this. Additionally, I update the testing infra in the PR for eip7823, to ensure all the output and gas usage is correct. Please feel free to add more cases to test the upper bound. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!! Thanks 🫡
🗒️ Description
This PR adds additional zero edge cases to the ModExp (EIP-7883) gas cost tests. These new test cases improve coverage by testing various combinations of empty and zero-valued inputs for base, exponent, and modulus parameters.
The changes specifically add test cases Z1-Z7 and Z11-Z15 to test edge cases where:
🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.