-
Notifications
You must be signed in to change notification settings - Fork 171
chore(tests): fix modexp conftest for tx gas limit cap #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added a |
Sorry yeah. We need to add this case manually: I thought it was in the PR. Will push it just now. |
5d10cac
to
2d1326e
Compare
c8d45a9
to
c8c463f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I will try the remaining refactoring in my PR, thanks for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment, I think current solution could be improved because future changes might break tests if we are not careful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ποΈ Description
Fixes the tx gas limit cap (from EIP-7825) for ModExp (EIP-7883) tests.
π Related Issues or PRs
#2108
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.