Skip to content

feat(tests): add worst case tests for PUSH opcodes #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

feat(tests): add worst case tests for PUSH opcodes #1762

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8537b8
feat(tests): add worst case tests for PUSH opcodes
LouisTsai-Csie Jun 17, 2025
7f26a74
refactor(tests): simplify push opcode parameterization
LouisTsai-Csie Jun 18, 2025
899728c
refactor(tests): use dynamic max stack height
LouisTsai-Csie Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions tests/zkevm/test_worst_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1869,3 +1869,74 @@ def test_worst_dup(
post={},
tx=tx,
)


@pytest.mark.parametrize(
"opcode",
[
pytest.param(Op.PUSH0),
pytest.param(Op.PUSH1),
pytest.param(Op.PUSH2),
pytest.param(Op.PUSH3),
pytest.param(Op.PUSH4),
pytest.param(Op.PUSH5),
pytest.param(Op.PUSH6),
pytest.param(Op.PUSH7),
pytest.param(Op.PUSH8),
pytest.param(Op.PUSH9),
pytest.param(Op.PUSH10),
pytest.param(Op.PUSH11),
pytest.param(Op.PUSH12),
pytest.param(Op.PUSH13),
pytest.param(Op.PUSH14),
pytest.param(Op.PUSH15),
pytest.param(Op.PUSH16),
pytest.param(Op.PUSH17),
pytest.param(Op.PUSH18),
pytest.param(Op.PUSH19),
pytest.param(Op.PUSH20),
pytest.param(Op.PUSH21),
pytest.param(Op.PUSH22),
pytest.param(Op.PUSH23),
pytest.param(Op.PUSH24),
pytest.param(Op.PUSH25),
pytest.param(Op.PUSH26),
pytest.param(Op.PUSH27),
pytest.param(Op.PUSH28),
pytest.param(Op.PUSH29),
pytest.param(Op.PUSH30),
pytest.param(Op.PUSH31),
pytest.param(Op.PUSH32),
],
)
def test_worst_push(
state_test: StateTestFiller,
pre: Alloc,
fork: Fork,
opcode: Op,
):
"""Test running a block with as many PUSH as possible."""
env = Environment()

op = opcode[1] if opcode.has_data_portion() else opcode
opcode_sequence = op * fork.max_stack_height()
target_contract_address = pre.deploy_contract(code=opcode_sequence)

calldata = Bytecode()
attack_block = Op.POP(Op.STATICCALL(Op.GAS, target_contract_address, 0, 0, 0, 0))

code = code_loop_precompile_call(calldata, attack_block, fork)
code_address = pre.deploy_contract(code=code)

tx = Transaction(
to=code_address,
gas_limit=env.gas_limit,
sender=pre.fund_eoa(),
)

state_test(
env=env,
pre=pre,
post={},
tx=tx,
)
Loading