-
Notifications
You must be signed in to change notification settings - Fork 148
feat(tests): add worst case tests for PUSH opcodes #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments and we can merge, thanks!
#1768 is merged now, could you try rebasing and fix conflicts so we can merge pls? |
756386c
to
665a261
Compare
Needs a rebase since git merge seems to be confusing the PUSH and SWAP tests. |
I will wait for the PR #1767 to be merged, or I will need to rebase again. |
#1767 is now merged, we can rebase 👍 |
e040918
to
899728c
Compare
🗒️ Description
This test case is designed to simulate the worst-case scenario for the PUSH operation in the EVM. It includes two approaches:
STATICCALL
to the first contract.Based on the discussion in Berlinterop, and the analysis in PR #1737, we would only try the second approach
🔗 Related Issues
Issue #1687
✅ Checklist
with removal of converted JSON/YML blockchain tests from ethereum/tests have been opened.