Skip to content

Fix lint for antithesis README #20671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix lint for antithesis README #20671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/antithesis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ docker images | grep etcd-client

It should show something like:

```
```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time you didn't change line 48. Any reason why? Are you sure static analysis is failing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that line. Sorry was multitasking and only addressed the part you commented. I just added line 48.

For both of these, they didn't make the static analysis fail, but a warning. Would be best to correct them.

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/20668/pull-etcd-markdown-lint/1967406674780098560

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't care about warnings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I abandon this PR and remove the same changes on the original PR?

etcd-client latest <IMAGE_ID> <DATE>
```

Expand All @@ -45,7 +45,7 @@ The command uses the etcd client and server images built from step 1.

The client will continuously check the health of the etcd nodes and print logs similar to:

```
```bash
[+] Running 4/4
✔ Container etcd0 Created 0.0s
✔ Container etcd2 Created 0.0s
Expand Down