Skip to content

Conversation

nwnt
Copy link
Member

@nwnt nwnt commented Sep 15, 2025

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

It should show something like:

```
```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time you didn't change line 48. Any reason why? Are you sure static analysis is failing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that line. Sorry was multitasking and only addressed the part you commented. I just added line 48.

For both of these, they didn't make the static analysis fail, but a warning. Would be best to correct them.

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/20668/pull-etcd-markdown-lint/1967406674780098560

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't care about warnings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I abandon this PR and remove the same changes on the original PR?

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.20%. Comparing base (ab3f19a) to head (834e5a2).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

see 54 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20671      +/-   ##
==========================================
- Coverage   68.80%   66.20%   -2.61%     
==========================================
  Files         418      420       +2     
  Lines       34707    34794      +87     
==========================================
- Hits        23879    23034     -845     
- Misses       9435    10346     +911     
- Partials     1393     1414      +21     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3f19a...834e5a2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt nwnt force-pushed the antithesis-fix-lint-README branch from 6ea97fa to 834e5a2 Compare September 15, 2025 15:17
@k8s-ci-robot
Copy link

@nwnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-amd64 834e5a2 link true /test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nwnt nwnt closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants