-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Fix lint for antithesis README #20671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It should show something like: | ||
|
||
``` | ||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time you didn't change line 48. Any reason why? Are you sure static analysis is failing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about that line. Sorry was multitasking and only addressed the part you commented. I just added line 48.
For both of these, they didn't make the static analysis fail, but a warning. Would be best to correct them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't care about warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I abandon this PR and remove the same changes on the original PR?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 54 files with indirect coverage changes @@ Coverage Diff @@
## main #20671 +/- ##
==========================================
- Coverage 68.80% 66.20% -2.61%
==========================================
Files 418 420 +2
Lines 34707 34794 +87
==========================================
- Hits 23879 23034 -845
- Misses 9435 10346 +911
- Partials 1393 1414 +21 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Nont <[email protected]>
6ea97fa
to
834e5a2
Compare
@nwnt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Per: #20668 (comment)
@serathius