feat: New citar-no-export-fields variable #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
arifer612
added a commit
to arifer612/citar
that referenced
this pull request
Nov 7, 2025
This ensures that the `bibtex-beginning-of-entry', `bibtex-search-forward-field', and `bibtex-set-dialect' functions in citar.el are loaded before attempting to byte-compile the file. This should resolve the issue in emacs-citar#872 (comment).
arifer612
added a commit
to arifer612/citar
that referenced
this pull request
Nov 7, 2025
This ensures that the `bibtex-beginning-of-entry', `bibtex-search-forward-field', and `bibtex-set-dialect' functions in citar.el are loaded before attempting to byte-compile the file. This should resolve the issue in emacs-citar#872 (comment).
arifer612
force-pushed
the
feat/no-export-fields
branch
from
a9be5af to
a763d58
Compare
arifer612
added a commit
to arifer612/citar
that referenced
this pull request
Nov 7, 2025
This ensures that the `bibtex-beginning-of-entry', `bibtex-search-forward-field', and `bibtex-set-dialect' functions in citar.el are loaded before attempting to byte-compile the file. This should resolve the issue in emacs-citar#872 (comment).
arifer612
force-pushed
the
feat/no-export-fields
branch
2 times, most recently
from
c2b4779 to
e1b59d6
Compare
arifer612
added a commit
to arifer612/citar
that referenced
this pull request
Nov 7, 2025
This ensures that the `bibtex-beginning-of-entry', `bibtex-search-forward-field', and `bibtex-set-dialect' functions in citar.el are loaded before attempting to byte-compile the file. This should resolve the issue in emacs-citar#872 (comment).
arifer612
force-pushed
the
feat/no-export-fields
branch
from
e1b59d6 to
ed3776c
Compare
Contributor
Author
|
I unfortunately did not realise that force pushes on my forked branch would trigger the workflows despite having changed this PR to a draft. Please ignore those workflow requests. This PR is put on hold until #873 is reviewed and accepted, as that PR resolves the CI byte-compilation check issue raised above, and more. |
bdarcus
pushed a commit
that referenced
this pull request
Nov 7, 2025
This ensures that the `bibtex-beginning-of-entry', `bibtex-search-forward-field', and `bibtex-set-dialect' functions in citar.el are loaded before attempting to byte-compile the file. This should resolve the issue in #872 (comment).
arifer612
force-pushed
the
feat/no-export-fields
branch
from
ed3776c to
b5f5798
Compare
Contributor
Author
|
Now that #873 has been merged, this PR is ready to be reviewed again. |
roshanshariff
requested changes
Nov 8, 2025
Collaborator
roshanshariff
left a comment
roshanshariff
left a comment
There was a problem hiding this comment.
I just suggested renaming the customization option, but otherwise this looks good to me!
arifer612
force-pushed
the
feat/no-export-fields
branch
from
b5f5798 to
c99a7fe
Compare
This commit adds a new custom variable, i.e., `citar-bibtex-no-export-fields', which serves a similar purpose to `bibtex-completion-no-export-fields' found in bibtex-completion. It is a list of bibtex fields that will be used to inform `citar--insert-bibtex' to omit out when exporting/inserting bibtex entries.
…ields This commit extends the `citar--insert-bibtex' function to omit bibtex fields that were declared in `citar-bibtex-no-export-fields' in the bibtex entry that is to be exported/inserted. This mirrors what is done by `bibtex-completion-insert-bibtex' when the `bibtex-completion-no-export-fields' variable is non-nil.
arifer612
force-pushed
the
feat/no-export-fields
branch
from
c99a7fe to
1698123
Compare
Contributor
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #868