refactor: byte-compilation errors #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the `bibtex-beginning-of-entry', `bibtex-search-forward-field', and `bibtex-set-dialect' functions in citar.el are loaded before attempting to byte-compile the file. This should resolve the issue in emacs-citar#872 (comment).
According to the help message for `ignore-error', the error condition should not be quoted. This will raise an error when byte-compiling in Emacs 30.2.
The value type for the custom variable `citar-display-transform-functions' is currently set to `list', which is not a proper elisp type. This will raise an error when attempting to byte-compile the file. Instead, the correct value-type should be sexp. Moreover, as there nothing is being evaluated, the backtick quotation should be replaced with a regular quotation to avoid unexpected expansion of the sexp.
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some parts of
citar.elandcitar-file.el. It resolves the byte-compilation errors in the current CI workflow, and more. In particular, it resolves the errors arising from:bibtexCI #472, CI #471, and CI #470.ignore-errorstatement arifer612/citar CI #1.citar-display-transform-functionscustom variable arifer612/citar CI #2.Changes made
The changes made are as follows.
(require 'bibtex)statement in the preamble ofcitar.el. This resolves the issue discussed in feat: New citar-no-export-fields variable #872 (comment).ignore-errorfunction incitar.el.citar-display-transform-functions.More details are included in the commit messages.
Validation
These changes successfully passes the current CI workflow (see arifer612/citar CI #4). There is, however, a possible issue with the linter that should be resolved separately.