-
Notifications
You must be signed in to change notification settings - Fork 8.5k
updating error message when config has enabled flag not in schema #241365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hammad-nasir-elastic
wants to merge
6
commits into
elastic:main
Choose a base branch
from
hammad-nasir-elastic:human-friendly-error-message-enabled-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−5
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bb18643
adding more human friendly error message when config has enabled flag…
hammad-nasir-elastic 3fc50d0
Merge branch 'main' into human-friendly-error-message-enabled-flag
hammad-nasir-elastic b67025a
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 82be224
fixing lint errors
hammad-nasir-elastic dc5f2d7
Merge branch 'main' into human-friendly-error-message-enabled-flag
hammad-nasir-elastic 403c262
Merge branch 'main' into human-friendly-error-message-enabled-flag
hammad-nasir-elastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so these are ultimately schema checks and we do have a better way to handle throwing custom validation errors within the schema validate function itself. https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-config-schema/README.md#custom-validation
any reason why you did not do that here instead of catching and rethrowing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I reviewed the custom validation you shared, and from what I understand, it would mean adding custom validation to each plugin’s schema for plugins that don’t use the enabled field. To avoid updating all those plugins and because the
isEnabledAtPathfunction is called for every discovered plugin when kibana is booting up, I figured I would do a try catch around the specific scenario in the code instead.I also based my changes on the comments in this PR which I think suggest catching and throwing a specific error message.
Let me know if I missed anything or if you have other suggestions!