updating error message when config has enabled flag not in schema

[hammad-nasir-elastic]

Resolves issue

Summary

Updating the error message in config_service.ts for the special use case when the provided config includes an enabled field and the validated config does not. The error message is more human friendly and specific to the enabled setting.

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 82be224

Failed CI Steps

• FTR Configs #36

Test Failures

• [job] [logs] FTR Configs #36 / cases security and spaces enabled: basic Kibana index: Alerting & Cases "before all" hook for "migrates the cases SO from the .kibana index to the .kibana_alerting_cases correctly"

Metrics [docs]

✅ unchanged

History

• 💔 Build #356965 failed b67025a

cc @hammad-nasir-elastic

[Bamieh]

so these are ultimately schema checks and we do have a better way to handle throwing custom validation errors within the schema validate function itself. https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-config-schema/README.md#custom-validation

any reason why you did not do that here instead of catching and rethrowing?

[hammad-nasir-elastic]

Hello! I reviewed the custom validation you shared, and from what I understand, it would mean adding custom validation to each plugin’s schema for plugins that don’t use the enabled field. To avoid updating all those plugins and because the isEnabledAtPath function is called for every discovered plugin when kibana is booting up, I figured I would do a try catch around the specific scenario in the code instead.

I also based my changes on the comments in this PR which I think suggest catching and throwing a specific error message.

Let me know if I missed anything or if you have other suggestions!