-
Notifications
You must be signed in to change notification settings - Fork 190
Add buildkite pipeline for publishing to PyPI #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
2fb3b14
to
b7ca75d
Compare
10c5e86
to
f06b27b
Compare
artifact_paths: | ||
- "perf8-report-*/**/*" | ||
|
||
- group: ":building_construction: Build Python Packages" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff.sh is used in here: https://github.com/elastic/connectors/blob/main/.buildkite/pipeline.yml#L84
We had a {major}.{minor}.{patch}.{release} available at some point, but since we release with stack it could be hard to organise well. We might need more strict QA process for it? I'd open a discussion with our team and potentially the clients team - they can give a good hint about it.
Additionally, if we feel like it's too much we can keep the current process for docker images around for now (same as we do now with |
44740b8
to
ab30eb8
Compare
65327f9
to
eb5072a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will connectors_sdk
pyproject.toml also consolidate .ruff.toml
, pytest.ini
and pyrightconfig.json
in this PR or a follow-up one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it in a follow-up, I was mainly focusing on the connectors_service
package as part of this PR.
3eb1b8c
to
43fc246
Compare
43fc246
to
915bb5a
Compare
Related to https://github.com/elastic/connectors-py/issues/10999
twine check
them; forconnectors_service
it will also install it and test the CLI entrypoints it exposes (e.g.connectors --help
)pyproject.toml
pytest
,pyright
, andruff
config intopyproject.toml
and removed individual fileslicense
inpyproject.toml
to avoid deprecation warnings (removal in 2026) - see warnings herepackages
inpyproject.toml
to avoid "ambiguous packages" warning - see warning here❓ I don't seenevermind, I was looking fordiff.sh
used anywhere.. can I delete it or am I missing sth?diff.sh
instead of justdiff
✍️ Process moving forward
Daily per PR:
pipeline.yml
will contain:.tar.gz
and.whl
of our packages (TODO)Release day:
TODO:
catalog-info.yml
Checklists
Pre-Review Checklist
config.yml.example
)v7.13.2
,v7.14.0
,v8.0.0
)Changes Requiring Extra Attention
Related Pull Requests
Release Note