-
Notifications
You must be signed in to change notification settings - Fork 190
[WIP] PyPI-publishable connectors_service
#3738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fe1993
to
1ca340c
Compare
1ca340c
to
63379b7
Compare
866e3ac
to
8e6432d
Compare
96f95a1
to
5acfca2
Compare
5acfca2
to
7d15026
Compare
Closing this in favour of #3748 - renaming the package is heavy and technically we can get away without it for now. It's just that it's a slightly surprising folder structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/elastic/search-team/issues/10999
.buildkite/pypi-publish-pipeline.yml
app/connectors_service/connectors
toapp/connectors_service/connectors_service
pyproject.toml
.buildkite/run_notice_check.sh
for the new folder structure when there's a change in any NOTICE.txtChecklists
Pre-Review Checklist
config.yml.example
)v7.13.2
,v7.14.0
,v8.0.0
)Changes Requiring Extra Attention
Related Pull Requests
Release Note