Skip to content

Add ability to remove Games that are removed from GOG Account from Manifest #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to remove Games that are removed from GOG Account from Manifest #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions gogrepo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,7 @@ def cmd_update(os_list, lang_list, skipknown, updateonly, id):
items = []
item_count = 0
known_ids = []
known_titles = []
i = 0

load_cookies()
Expand All @@ -575,10 +576,13 @@ def cmd_update(os_list, lang_list, skipknown, updateonly, id):
api_url += "/getFilteredProducts"

# Make convenient list of known ids
if skipknown:
for item in gamesdb:
known_ids.append(item.id)
for item in gamesdb:
known_ids.append(item.id)

for item in gamesdb:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple iterations over the same data, can be handled in one for loop.

known_titles.append(item.title)


# Fetch shelf data
done = False
while not done:
Expand Down Expand Up @@ -629,18 +633,43 @@ def cmd_update(os_list, lang_list, skipknown, updateonly, id):
if i >= json_data['totalPages']:
done = True

if not id and not updateonly and not skipknown:
validIDs = [item.id for item in items]
invalidItems = [itemID for itemID in known_ids if itemID not in validIDs]
if len(invalidItems) != 0:
warn('old games in manifest. Removing ...')
for item in invalidItems:
warn('Removing id "{}" from manifest'.format(item))
item_idx = item_checkdb(item, gamesdb)
if item_idx is not None:
del gamesdb[item_idx]

# bail if there's nothing to do
if len(items) == 0:
if id:
warn('game id "{}" was not found in your product data'.format(id))
if (int(id) in known_ids or id in known_titles):
if (int(id) in known_ids):
warn('but was found in manifest. Removing from manifest...')
item_idx = item_checkdb(int(id), gamesdb)
if item_idx is not None:
del gamesdb[item_idx]
if (id in known_titles):
warn('but was found in manifest. Removing from manifest...')
gameToRemove = [item for item in gamesdb if item.title == id][0]
item_idx = item_checkdb(gameToRemove.id, gamesdb)
if item_idx is not None:
del gamesdb[item_idx]
save_manifest(gamesdb)
elif updateonly:
warn('no new game updates found.')
elif skipknown:
warn('no new games found.')
else:
warn('nothing to do')
return



items_count = len(items)
print_padding = len(str(items_count))
if not id and not updateonly and not skipknown:
Expand Down