Skip to content

Conversation

Kalanyr
Copy link

@Kalanyr Kalanyr commented Nov 7, 2016

GOG removed Sunless_Sea_Zubmariner and merged it into Sunless Sea as DLC , gogrepo can't handle this.
This adds that facility, if an update by ID is done (number or name) and not found on GOG but is in the manifst, it deletes the manifest entry. Likewise if a full update (not skipknown or update) is done, it will remove any games from the manifest that are no longer present on the GOG account.

This isn't just a convenience feature either, the old items being in the manifest means that clean doesn't remove the files, and download will try and download them from locations on GOG that never exist, which results in errors.

@Kalanyr Kalanyr changed the title Add ability to remove Games that are removed from GOG Account from Manifst Add ability to remove Games that are removed from GOG Account from Manifest Nov 7, 2016
@eddie3
Copy link
Owner

eddie3 commented Nov 7, 2016

Thanks for the PR Kalanyr. This is something I've been meaning to get around to fixing. I hope to review your PR and test it this week, along with the other PRs.

for item in gamesdb:
known_ids.append(item.id)

for item in gamesdb:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple iterations over the same data, can be handled in one for loop.

@HamsterExAstris
Copy link
Contributor

Are the following errors what you were seeing? (Don't want to spend time chasing this down if you already have a fix. :))

13:42:56 | (1 / 1) fetching game details for wasteland_2_directors_cut...
13:43:20 | request failed: HTTP Error 404: Not Found. will not retry.
13:43:20 | failed to fetch https://www.gog.com/downlink/file/wasteland_2_directors_cut_digital_deluxe_edition_upgrade/34743

13:44:04 | (1 / 1) fetching game details for wasteland_2_kickstarter...
13:44:40 | request failed: HTTP Error 404: Not Found. will not retry.
13:44:40 | failed to fetch https://www.gog.com/downlink/file/wasteland_2_directors_cut_digital_deluxe_edition_upgrade/34743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants