Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<99da5cf948e469e385bd70b4c59cd764>>
* @generated SignedSource<<a482d8bfae45b34898278328a0eb20c0>>
*/

/**
Expand Down Expand Up @@ -101,16 +101,16 @@ public object ReactNativeFeatureFlags {
public fun enableFabricRenderer(): Boolean = accessor.enableFabricRenderer()

/**
* Synchronise the view command dispatching with mounting of new transaction
* This feature flag enables a fix for reparenting fix in differentiator
*/
@JvmStatic
public fun enableFixForViewCommandRace(): Boolean = accessor.enableFixForViewCommandRace()
public fun enableFixForParentTagDuringReparenting(): Boolean = accessor.enableFixForParentTagDuringReparenting()

/**
* When enabled, the renderer would only fail commits when they propagate state and the last commit that updated state changed before committing.
* Enables font scale changes updating layout for measurable nodes.
*/
@JvmStatic
public fun enableGranularShadowTreeStateReconciliation(): Boolean = accessor.enableGranularShadowTreeStateReconciliation()
public fun enableFontScaleChangesUpdatingLayout(): Boolean = accessor.enableFontScaleChangesUpdatingLayout()

/**
* iOS Views will clip to their padding box vs border box
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5e1d8c0e728715d4110b6d1d156357c5>>
* @generated SignedSource<<cb75c549c17f6a8fe5036f0c5babc5ca>>
*/

/**
Expand Down Expand Up @@ -32,8 +32,8 @@ public class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccesso
private var enableEventEmitterRetentionDuringGesturesOnAndroidCache: Boolean? = null
private var enableFabricLogsCache: Boolean? = null
private var enableFabricRendererCache: Boolean? = null
private var enableFixForViewCommandRaceCache: Boolean? = null
private var enableGranularShadowTreeStateReconciliationCache: Boolean? = null
private var enableFixForParentTagDuringReparentingCache: Boolean? = null
private var enableFontScaleChangesUpdatingLayoutCache: Boolean? = null
private var enableIOSViewClipToPaddingBoxCache: Boolean? = null
private var enableImagePrefetchingAndroidCache: Boolean? = null
private var enableLayoutAnimationsOnAndroidCache: Boolean? = null
Expand Down Expand Up @@ -175,20 +175,20 @@ public class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccesso
return cached
}

override fun enableFixForViewCommandRace(): Boolean {
var cached = enableFixForViewCommandRaceCache
override fun enableFixForParentTagDuringReparenting(): Boolean {
var cached = enableFixForParentTagDuringReparentingCache
if (cached == null) {
cached = ReactNativeFeatureFlagsCxxInterop.enableFixForViewCommandRace()
enableFixForViewCommandRaceCache = cached
cached = ReactNativeFeatureFlagsCxxInterop.enableFixForParentTagDuringReparenting()
enableFixForParentTagDuringReparentingCache = cached
}
return cached
}

override fun enableGranularShadowTreeStateReconciliation(): Boolean {
var cached = enableGranularShadowTreeStateReconciliationCache
override fun enableFontScaleChangesUpdatingLayout(): Boolean {
var cached = enableFontScaleChangesUpdatingLayoutCache
if (cached == null) {
cached = ReactNativeFeatureFlagsCxxInterop.enableGranularShadowTreeStateReconciliation()
enableGranularShadowTreeStateReconciliationCache = cached
cached = ReactNativeFeatureFlagsCxxInterop.enableFontScaleChangesUpdatingLayout()
enableFontScaleChangesUpdatingLayoutCache = cached
}
return cached
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<b8035f8bf1833723858be474f7766594>>
* @generated SignedSource<<f24ac028449dd09db4e6fc325d2d1bd4>>
*/

/**
Expand Down Expand Up @@ -52,9 +52,9 @@ public object ReactNativeFeatureFlagsCxxInterop {

@DoNotStrip @JvmStatic public external fun enableFabricRenderer(): Boolean

@DoNotStrip @JvmStatic public external fun enableFixForViewCommandRace(): Boolean
@DoNotStrip @JvmStatic public external fun enableFixForParentTagDuringReparenting(): Boolean

@DoNotStrip @JvmStatic public external fun enableGranularShadowTreeStateReconciliation(): Boolean
@DoNotStrip @JvmStatic public external fun enableFontScaleChangesUpdatingLayout(): Boolean

@DoNotStrip @JvmStatic public external fun enableIOSViewClipToPaddingBox(): Boolean

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<11d93a900862ed8ce98f90f9af2de47b>>
* @generated SignedSource<<c99bff5f6032951601f6439c79cdbffd>>
*/

/**
Expand Down Expand Up @@ -47,9 +47,9 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun enableFabricRenderer(): Boolean = false

override fun enableFixForViewCommandRace(): Boolean = false
override fun enableFixForParentTagDuringReparenting(): Boolean = false

override fun enableGranularShadowTreeStateReconciliation(): Boolean = false
override fun enableFontScaleChangesUpdatingLayout(): Boolean = false

override fun enableIOSViewClipToPaddingBox(): Boolean = false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<0614fa80cbc66806fa45aef70f34e2d7>>
* @generated SignedSource<<a80e0caafa18fc7ce4f889f7f9cc4373>>
*/

/**
Expand Down Expand Up @@ -36,8 +36,8 @@ public class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcces
private var enableEventEmitterRetentionDuringGesturesOnAndroidCache: Boolean? = null
private var enableFabricLogsCache: Boolean? = null
private var enableFabricRendererCache: Boolean? = null
private var enableFixForViewCommandRaceCache: Boolean? = null
private var enableGranularShadowTreeStateReconciliationCache: Boolean? = null
private var enableFixForParentTagDuringReparentingCache: Boolean? = null
private var enableFontScaleChangesUpdatingLayoutCache: Boolean? = null
private var enableIOSViewClipToPaddingBoxCache: Boolean? = null
private var enableImagePrefetchingAndroidCache: Boolean? = null
private var enableLayoutAnimationsOnAndroidCache: Boolean? = null
Expand Down Expand Up @@ -191,22 +191,22 @@ public class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcces
return cached
}

override fun enableFixForViewCommandRace(): Boolean {
var cached = enableFixForViewCommandRaceCache
override fun enableFixForParentTagDuringReparenting(): Boolean {
var cached = enableFixForParentTagDuringReparentingCache
if (cached == null) {
cached = currentProvider.enableFixForViewCommandRace()
accessedFeatureFlags.add("enableFixForViewCommandRace")
enableFixForViewCommandRaceCache = cached
cached = currentProvider.enableFixForParentTagDuringReparenting()
accessedFeatureFlags.add("enableFixForParentTagDuringReparenting")
enableFixForParentTagDuringReparentingCache = cached
}
return cached
}

override fun enableGranularShadowTreeStateReconciliation(): Boolean {
var cached = enableGranularShadowTreeStateReconciliationCache
override fun enableFontScaleChangesUpdatingLayout(): Boolean {
var cached = enableFontScaleChangesUpdatingLayoutCache
if (cached == null) {
cached = currentProvider.enableGranularShadowTreeStateReconciliation()
accessedFeatureFlags.add("enableGranularShadowTreeStateReconciliation")
enableGranularShadowTreeStateReconciliationCache = cached
cached = currentProvider.enableFontScaleChangesUpdatingLayout()
accessedFeatureFlags.add("enableFontScaleChangesUpdatingLayout")
enableFontScaleChangesUpdatingLayoutCache = cached
}
return cached
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5f4ff90382b2d69df401535cb33e64c5>>
* @generated SignedSource<<76da11369c2f7b8955a154a63af374a3>>
*/

/**
Expand Down Expand Up @@ -47,9 +47,9 @@ public interface ReactNativeFeatureFlagsProvider {

@DoNotStrip public fun enableFabricRenderer(): Boolean

@DoNotStrip public fun enableFixForViewCommandRace(): Boolean
@DoNotStrip public fun enableFixForParentTagDuringReparenting(): Boolean

@DoNotStrip public fun enableGranularShadowTreeStateReconciliation(): Boolean
@DoNotStrip public fun enableFontScaleChangesUpdatingLayout(): Boolean

@DoNotStrip public fun enableIOSViewClipToPaddingBox(): Boolean

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<28069af1f34c79e9907c85697a291c0e>>
* @generated SignedSource<<e877dbd11729fd955f1e04c8436a47af>>
*/

/**
Expand Down Expand Up @@ -111,15 +111,15 @@ class ReactNativeFeatureFlagsProviderHolder
return method(javaProvider_);
}

bool enableFixForViewCommandRace() override {
bool enableFixForParentTagDuringReparenting() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableFixForViewCommandRace");
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableFixForParentTagDuringReparenting");
return method(javaProvider_);
}

bool enableGranularShadowTreeStateReconciliation() override {
bool enableFontScaleChangesUpdatingLayout() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableGranularShadowTreeStateReconciliation");
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableFontScaleChangesUpdatingLayout");
return method(javaProvider_);
}

Expand Down Expand Up @@ -379,14 +379,14 @@ bool JReactNativeFeatureFlagsCxxInterop::enableFabricRenderer(
return ReactNativeFeatureFlags::enableFabricRenderer();
}

bool JReactNativeFeatureFlagsCxxInterop::enableFixForViewCommandRace(
bool JReactNativeFeatureFlagsCxxInterop::enableFixForParentTagDuringReparenting(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::enableFixForViewCommandRace();
return ReactNativeFeatureFlags::enableFixForParentTagDuringReparenting();
}

bool JReactNativeFeatureFlagsCxxInterop::enableGranularShadowTreeStateReconciliation(
bool JReactNativeFeatureFlagsCxxInterop::enableFontScaleChangesUpdatingLayout(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::enableGranularShadowTreeStateReconciliation();
return ReactNativeFeatureFlags::enableFontScaleChangesUpdatingLayout();
}

bool JReactNativeFeatureFlagsCxxInterop::enableIOSViewClipToPaddingBox(
Expand Down Expand Up @@ -617,11 +617,11 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
"enableFabricRenderer",
JReactNativeFeatureFlagsCxxInterop::enableFabricRenderer),
makeNativeMethod(
"enableFixForViewCommandRace",
JReactNativeFeatureFlagsCxxInterop::enableFixForViewCommandRace),
"enableFixForParentTagDuringReparenting",
JReactNativeFeatureFlagsCxxInterop::enableFixForParentTagDuringReparenting),
makeNativeMethod(
"enableGranularShadowTreeStateReconciliation",
JReactNativeFeatureFlagsCxxInterop::enableGranularShadowTreeStateReconciliation),
"enableFontScaleChangesUpdatingLayout",
JReactNativeFeatureFlagsCxxInterop::enableFontScaleChangesUpdatingLayout),
makeNativeMethod(
"enableIOSViewClipToPaddingBox",
JReactNativeFeatureFlagsCxxInterop::enableIOSViewClipToPaddingBox),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<763d595784bdf31a852ebf2a492a1393>>
* @generated SignedSource<<e0ca5927c65c857463973df1f34f4b9d>>
*/

/**
Expand Down Expand Up @@ -66,10 +66,10 @@ class JReactNativeFeatureFlagsCxxInterop
static bool enableFabricRenderer(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool enableFixForViewCommandRace(
static bool enableFixForParentTagDuringReparenting(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool enableGranularShadowTreeStateReconciliation(
static bool enableFontScaleChangesUpdatingLayout(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool enableIOSViewClipToPaddingBox(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<511c1667fab247b77d771a7a26e87b46>>
* @generated SignedSource<<5ee10cdf8f5e3695ce4f73373291935e>>
*/

/**
Expand Down Expand Up @@ -74,12 +74,12 @@ bool ReactNativeFeatureFlags::enableFabricRenderer() {
return getAccessor().enableFabricRenderer();
}

bool ReactNativeFeatureFlags::enableFixForViewCommandRace() {
return getAccessor().enableFixForViewCommandRace();
bool ReactNativeFeatureFlags::enableFixForParentTagDuringReparenting() {
return getAccessor().enableFixForParentTagDuringReparenting();
}

bool ReactNativeFeatureFlags::enableGranularShadowTreeStateReconciliation() {
return getAccessor().enableGranularShadowTreeStateReconciliation();
bool ReactNativeFeatureFlags::enableFontScaleChangesUpdatingLayout() {
return getAccessor().enableFontScaleChangesUpdatingLayout();
}

bool ReactNativeFeatureFlags::enableIOSViewClipToPaddingBox() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<19cfd8b41dd429c83a5e0f0df514d1d1>>
* @generated SignedSource<<c3b70d43d96674bcd908c8e595df321e>>
*/

/**
Expand Down Expand Up @@ -100,14 +100,14 @@ class ReactNativeFeatureFlags {
RN_EXPORT static bool enableFabricRenderer();

/**
* Synchronise the view command dispatching with mounting of new transaction
* This feature flag enables a fix for reparenting fix in differentiator
*/
RN_EXPORT static bool enableFixForViewCommandRace();
RN_EXPORT static bool enableFixForParentTagDuringReparenting();

/**
* When enabled, the renderer would only fail commits when they propagate state and the last commit that updated state changed before committing.
* Enables font scale changes updating layout for measurable nodes.
*/
RN_EXPORT static bool enableGranularShadowTreeStateReconciliation();
RN_EXPORT static bool enableFontScaleChangesUpdatingLayout();

/**
* iOS Views will clip to their padding box vs border box
Expand Down
Loading
Loading