fix incorrect parentTag coming from differentiator when reparenting (… #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acebook#50842) Summary: Pull Request resolved: facebook#50842 changelog: [internal] introduce a feature flag that fixes incorrect parentTag coming from differentiator when reparenting. The problem occurs under very specific circumstances that are covered by an integration test. The *parentTag* is also [only used on Android](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp#L566) and only if layout changes as part of the update. This diff introduces a new test specifically triggering the incorrect behaviour: `Differentiator-itest.js`. Without this fix, the test fails on following assert: [react_native_assert(hasTag(mutation.parentTag))](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/mounting/stubs/StubViewTree.cpp#L245). This diff also converts existing tests for the differentiator to parametrised tests and enables the fix. Reviewed By: rubennorte Differential Revision: D73428312 fbshipit-source-id: 8b00977b610a85fba8b01a50a151f30bd5321ed4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: Fix incorrect parentTag coming from differentiator when reparenting (#50842)
Summary:
This cherry-picks upstream commit 8b00977 into our fork. It addresses a rare issue where the parentTag emitted from the differentiator is incorrect during reparenting scenarios, leading to assertion failures on Android when layout updates are involved.
This is done in hopes of fixing this issue