feat(btc-adapter): implement a hybrid header cache #6797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add_header, which may block on disk I/O. - to_socket_addrs, which is may block on DNS lookup.
THLO
reviewed
Sep 17, 2025
THLO
reviewed
Sep 17, 2025
THLO
reviewed
Sep 17, 2025
gregorydemay
approved these changes
Sep 17, 2025
Base automatically changed from
paulliu/improve-btc-adapter-async
to
master
September 17, 2025 19:03
mducroux
approved these changes
Sep 18, 2025
Co-authored-by: mducroux <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
Implement a hybrid header cache that would persist anchor header and its ancestors to disk. This leads to a simpler on-disk cache implementation, since it only has to persist a single chain of headers. The downside is that headers since the anchor point would be lost if the adapter is restarted, in which case it would sync more headers in order to catch up. --------- Co-authored-by: mducroux <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a hybrid header cache that would persist anchor header and its ancestors to disk.
This leads to a simpler on-disk cache implementation, since it only has to persist a single chain of headers.
The downside is that headers since the anchor point would be lost if the adapter is restarted, in which case it would sync more headers in order to catch up.