-
Notifications
You must be signed in to change notification settings - Fork 362
perf(dogecoin): benchmark adapter for adding Dogecoin block headers #6740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # rs/bitcoin/adapter/benches/e2e.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding these useful benchmarks @gregorydemay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left some questions.
Thanks @gregorydemay .
# Conflicts: # rs/bitcoin/adapter/benches/e2e.rs # rs/bitcoin/adapter/src/header_cache.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gregorydemay for providing the benchmarks! They are very useful
# Conflicts: # rs/bitcoin/adapter/benches/e2e.rs
# Conflicts: # rs/bitcoin/adapter/benches/e2e.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ninegua for the feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can always follow up on #6740 (comment)!
Follow-up on #6706 to benchmark the Dogecoin adapter when adding 800k Dogecoin block headers (with auxiliary proof of work) form mainnet.