CI: test all PnetCDF test programs #874
Conversation
wkliao
force-pushed
the
pnetcdf_workflow
branch
from
3ca71ff to
7f2d91d
Compare
|
Note this CI failed due to a bug in #873 |
| run: | | ||
| cd ${GITHUB_WORKSPACE}/PnetCDF/pnetcdf-${PNETCDF_VERSION} | ||
| make -s LIBTOOLFLAGS=--silent V=1 -j 8 tests > qout 2>&1 | ||
| export LD_PRELOAD=${GITHUB_WORKSPACE}/darshan_install/lib/libdarshan.so |
There was a problem hiding this comment.
Can we add simple logic here to test for existence of expected number of Darshan logs for these tests or something? You can see in the workflow output that no log files are created because we never set the DARSHAN_LOGPATH env variable. I think the least we could do is assert that the expected number of logs was generated (and that the log path is correctly set so Darshan can write them).
There was a problem hiding this comment.
Setting DARSHAN_LOGPATH has been added.
How does Darshah check the number of log files?
Note the number of PnetCDF test programs can increase in new releases.
| run: | | ||
| cd ${GITHUB_WORKSPACE}/PnetCDF/pnetcdf-${PNETCDF_VERSION} | ||
| export LD_PRELOAD=${GITHUB_WORKSPACE}/darshan_install/lib/libdarshan.so | ||
| make ptest |
There was a problem hiding this comment.
Check log files are correctly generated here, too? Later on, we could add a script that checks more in-depth details as part of the workflow, but something simple is fine for now.
There was a problem hiding this comment.
How does one check whether a Darshan log file is correct or not?
Download a PnetCDF official release and run its make check and make ptest when Darshan library is pre-loaded.
wkliao
force-pushed
the
pnetcdf_workflow
branch
from
4a2491d to
399cf1b
Compare
Download PnetCDF release and run its
make checkandmake ptestwhen Darshan library is pre-loaded.