Skip to content

added TokenList constructors with modern buffer wrappers and hide "unsafe" ones - if available #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2025
Merged

added TokenList constructors with modern buffer wrappers and hide "unsafe" ones - if available #496

merged 6 commits into from
Aug 29, 2025

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Supersedes #377.

@firewave firewave changed the title provide safe API for TokenList only provide "safe" API for TokenList out-of-the-box Aug 15, 2025
@firewave firewave changed the title only provide "safe" API for TokenList out-of-the-box make it possible to hide "unsafe" TokenList API Aug 15, 2025
@firewave firewave force-pushed the unsafe-api branch 4 times, most recently from 333f2dd to 8313678 Compare August 15, 2025 15:13
@firewave firewave changed the title make it possible to hide "unsafe" TokenList API added TokenList constructor with modern buffer wrappers and made it possible to hide "unsafe" ones Aug 15, 2025
@firewave firewave force-pushed the unsafe-api branch 7 times, most recently from 4229d04 to ea3a026 Compare August 15, 2025 21:56
@firewave firewave mentioned this pull request Aug 19, 2025
Open
@firewave
Copy link
Collaborator Author

This came up in a discussion in danmar/cppcheck#6379.

@firewave
Copy link
Collaborator Author

The added test is only to make sure it compiles. I will leverage #261 so it will actually be used for the input.

@firewave firewave force-pushed the unsafe-api branch 2 times, most recently from ddc8da8 to ae24823 Compare August 19, 2025 07:33
@firewave
Copy link
Collaborator Author

firewave commented Aug 19, 2025 •
edited
Loading

Not sure about the SIMPLECPP_UNSAFE_API name. The new constructors are just use modern wrappers and the user can still misuse them like the existing ones. Maybe SIMPLECPP_ENABLE_PTR_CTORS?

@firewave
Copy link
Collaborator Author

We could also add an overload with std::vector<char> so there's also a safer alternative for older standards.

@firewave firewave marked this pull request as ready for review August 21, 2025 12:46
@firewave
Copy link
Collaborator Author

Not sure about the SIMPLECPP_UNSAFE_API name. The new constructors are just use modern wrappers and the user can still misuse them like the existing ones. Maybe SIMPLECPP_ENABLE_PTR_CTORS?

Or SIMPLECPP_LEGACY_API?

@firewave
Copy link
Collaborator Author

I renamed the define to SIMPLECPP_TOKENLIST_ALLOW_PTR.

@firewave firewave mentioned this pull request Aug 29, 2025
Closed
@firewave firewave changed the title added TokenList constructor with modern buffer wrappers and made it possible to hide "unsafe" ones added TokenList constructors with modern buffer wrappers and made it possible to hide "unsafe" ones Aug 29, 2025
@firewave firewave changed the title added TokenList constructors with modern buffer wrappers and made it possible to hide "unsafe" ones added TokenList constructors with modern buffer wrappers and hide "unsafe" ones - if available Aug 29, 2025
danmar
danmar reviewed Aug 29, 2025
View reviewed changes
@firewave firewave merged commit 4056cd5 into danmar:master Aug 29, 2025
13 checks passed
@firewave firewave deleted the unsafe-api branch August 29, 2025 11:59
@jcfr jcfr mentioned this pull request Aug 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar