vendor(simplecpp): Update simplecpp.{h,cpp} to master (37fa4f4); was master (538c5c4) #284
+102
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ream changes This commit updates simplecpp patch `do_not_stop_on_error.patch` to account for upstream changes introduced through the commit danmar/simplecpp@3911fdd ("fixed some `Variable copied when it could be moved` Coverity warnings (#495)", 2025-08-29)
jcfr
changed the title
…master (538c5c4) Explicitly toggles the pointer-based legacy API by defining SIMPLECPP_TOKENLIST_ALLOW_PTR. This update also includes reapplying the `do_not_stop_on_error.patch`. --- Upstream: danmar/simplecpp@37fa4f4 Source date: 2025-08-30 Files: generator/simplecpp/simplecpp.h, generator/simplecpp/simplecpp.cpp Patch: generator/simplecpp/do_not_stop_on_error.patch re-applied Compare: danmar/simplecpp@538c5c4...37fa4f4
jcfr
force-pushed
the
update-simplecpp-to-latest
branch
from
fe13fed to
b2ed9c2
Compare
mrbean-bremen
approved these changes
Aug 31, 2025
There was a problem hiding this comment.
Thanks! As far as I can see, this is mostly about modernizing the code / better support for modern compilers / preparing better macOS support, and there are no real changes in the functionality concerning PythonQt usage.
Still would have @usiems to have a look, as he has introduced the usage of simplecpp.
usiems
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates simplecpp to the latest upstream master commit (danmar/simplecpp@37fa4f4) from the previous master (danmar/simplecpp@538c5c4).
Additionally, the pointer-based legacy API has been explicitly toggled by defining
SIMPLECPP_TOKENLIST_ALLOW_PTRto maintain compatibility with PythonQt.Tip
For rational behind the introduction of
SIMPLECPP_TOKENLIST_ALLOW_PTRTokenListconstructors with modern buffer wrappers and hide "unsafe" ones - if available danmar/simplecpp#496Note
Note that the PythonQt-specific patch
do_not_stop_on_error.patchhas also been updated to apply cleanlyImportant
This will then allow us to follow-up with another update backporting the support for framework introduced upstream through pull request:
-I,-isystem,-F,-iframework+ Darwin framework support (with legacy-Iback-compat) danmar/simplecpp#511Upstream: danmar/simplecpp@37fa4f4
Source date: 2025-08-30
Files:
Patch:
generator/simplecpp/do_not_stop_on_error.patchre-appliedCompare: danmar/simplecpp@538c5c4...37fa4f4
List of simplecpp changes: