Add superuser name for creation #1647
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2025
asmacdo
commented
May 28, 2025
This avoids creating dandisets with invalid metadata,
ie contributor name = ", "
asmacdo
force-pushed
the
create-superuser-with-name
branch
from
cb88079 to
46c41a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
- Coverage 88.75% 88.72% -0.04%
==========================================
Files 82 82
Lines 11438 11438
==========================================
- Hits 10152 10148 -4
- Misses 1286 1290 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating dandisets with invalid metadata, which is caused by this bugfix PR. Please see the description of that one for details.
ie contributor name = ", "
@yarikoptic this is ready for review, but I am leaving as a draft because:
this should not merge unless dandi-archive/2377 merges
these tests are failing because they are using dandi-archive image without the bugfix. (I could easily add cross-repo PR checkout logic for PRs like I did in the dandi-archive PR)
Remove failfast hack