Add superuser name for creation #1646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating dandisets with invalid metadata,
ie contributor name = ", "
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
- Coverage 88.84% 88.82% -0.02%
==========================================
Files 82 82
Lines 11434 11440 +6
==========================================
+ Hits 10158 10162 +4
- Misses 1276 1278 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
asmacdo
commented
May 28, 2025
| v = self.get_version(self.version_id) | ||
| if v.status is VersionStatus.VALID and not v.asset_validation_errors: | ||
| return | ||
| # TODO(asmacdo) can we fail fast? |
There was a problem hiding this comment.
This should be removed from this PR-- but without this each invalid dandiset waits for 2 minutes before failing.
|
Reopening from the upstream fork (requires pr functionality will need to be more complex to allow personal forks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating dandisets with invalid metadata,
ie contributor name = ", "
This will require changes in dandi-archive to pass.