Skip to content

Add superuser name for creation #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add superuser name for creation #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dandi/dandiapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,6 +1106,10 @@
v = self.get_version(self.version_id)
if v.status is VersionStatus.VALID and not v.asset_validation_errors:
return
# TODO(asmacdo) can we fail fast?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed from this PR-- but without this each invalid dandiset waits for 2 minutes before failing.

if v.status is VersionStatus.INVALID:
break

Check warning on line 1111 in dandi/dandiapi.py

View check run for this annotation

Codecov / codecov/patch

dandi/dandiapi.py#L1111 

Added line #L1111 was not covered by tests

sleep(0.5)
# TODO: Improve the presentation of the error messages
about = {
Expand Down
12 changes: 6 additions & 6 deletions dandi/tests/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,12 +434,16 @@ def docker_compose_setup() -> Iterator[dict[str, str]]:
"--rm",
"-e",
"DJANGO_SUPERUSER_PASSWORD=nsNc48DBiS",
"-e",
"[email protected]",
"-e",
"DJANGO_SUPERUSER_FIRST_NAME=Test",
"-e",
"DJANGO_SUPERUSER_LAST_NAME=Admin",
"django",
"./manage.py",
"createsuperuser",
"--no-input",
"--email",
"[email protected]",
],
cwd=str(LOCAL_DOCKER_DIR),
env=env,
Expand Down Expand Up @@ -578,10 +582,6 @@ def mkdandiset(self, name: str, embargo: bool = False) -> SampleDandiset:
{
"description": "A test Dandiset",
"license": ["spdx:CC0-1.0"],
# The contributor needs to be given explicitly here or else
# it'll be set based on the user account. For the Docker
# Compose setup, that would mean basing it on the admin user,
# whose name doesn't validate under dandischema.
"contributor": [
{
"schemaKey": "Person",
Expand Down
Loading