Skip to content

Conversation

TalDebi
Copy link

@TalDebi TalDebi commented Aug 31, 2025

No description provided.

@TalDebi TalDebi marked this pull request as draft August 31, 2025 13:24
Signed-off-by: maromcohen <[email protected]>
Copy link
Contributor

dana-prow-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TalDebi
Once this PR has been reviewed and has the lgtm label, please assign dvirgilad for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TalDebi TalDebi force-pushed the feature/rcs branch 4 times, most recently from 7e2df5c to 422f1ab Compare September 16, 2025 11:19
Copy link
Contributor

@dvirgilad dvirgilad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dvirgilad dvirgilad changed the title chore: add DefaultResources, InvalidHostnamePatterns to CappConfigSpec capp v2 Sep 18, 2025
@dvirgilad
Copy link
Contributor

Please resolve issue #258

@TalDebi TalDebi requested a review from dvirgilad September 21, 2025 08:49
@TalDebi TalDebi force-pushed the feature/rcs branch 3 times, most recently from 3e7e420 to af63bca Compare September 21, 2025 13:43
Signed-off-by: TalDebi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants