fix: refactor functions, add cert-manager yamls

Signed-off-by: TalDebi <[email protected]>

Author: maromcohen

Dockerfile

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.24.1 as builder
+FROM golang:1.24.6 as builder
 
 WORKDIR /workspace
 # Copy the Go Modules manifests

PROJECT

@@ -28,7 +28,7 @@ resources:
 - api:
     crdVersion: v1
     namespaced: true
-  domain: rcs.dana.io
+  domain: dana.io
   group: rcs
   kind: CappConfig
   path: github.com/dana-team/container-app-operator/api/rcs/v1alpha1

api/rcs/v1alpha1/cappconfig_types.go

@@ -21,10 +21,14 @@ import (
 	"flag"
 	"os"
 
+	"sigs.k8s.io/controller-runtime/pkg/webhook"
+	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
+
 	cmapi "github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1"
 
 	dnsrecordv1alpha1 "github.com/dana-team/provider-dns/apis/record/v1alpha1"
 
+	cappv1alpha1 "github.com/dana-team/container-app-operator/api/v1alpha1"
 	nfspvcv1alpha1 "github.com/dana-team/nfspvc-operator/api/v1alpha1"
 	"github.com/go-logr/zapr"
 	loggingv1beta1 "github.com/kube-logging/logging-operator/pkg/sdk/logging/api/v1beta1"
@@ -44,12 +48,10 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
-	rcsv1alpha1 "github.com/dana-team/container-app-operator/api/rcs/v1alpha1"
-	cappv1alpha1 "github.com/dana-team/container-app-operator/api/v1alpha1"
 	cappcontroller "github.com/dana-team/container-app-operator/internal/kinds/capp/controllers"
 	"github.com/dana-team/container-app-operator/internal/kinds/capp/utils"
 	crcontroller "github.com/dana-team/container-app-operator/internal/kinds/capprevision/controllers"
-	webhookrcsv1alpha1 "github.com/dana-team/container-app-operator/internal/webhook/rcs/v1alpha1"
+	webhooks "github.com/dana-team/container-app-operator/internal/webhook/rcs/v1alpha1"
 	// +kubebuilder:scaffold:imports
 )
 
@@ -68,7 +70,6 @@ func init() {
 	utilruntime.Must(cmapi.AddToScheme(scheme))
 	utilruntime.Must(dnsrecordv1alpha1.AddToScheme(scheme))
 
-	utilruntime.Must(rcsv1alpha1.AddToScheme(scheme))
 	// +kubebuilder:scaffold:scheme
 }
 
@@ -177,16 +178,17 @@ func main() {
 		setupLog.Error(err, "unable to create controller", "controller", "CappRevision")
 		os.Exit(1)
 	}
+
 	// nolint:goconst
 	if os.Getenv("ENABLE_WEBHOOKS") != "false" {
 		hookServer := mgr.GetWebhookServer()
 		decoder := admission.NewDecoder(scheme)
-		hookServer.Register(rcswebhooks.ValidatorServingPath, &webhook.Admission{Handler: &rcswebhooks.CappValidator{
+		hookServer.Register("/validate-capp", &webhook.Admission{Handler: &webhooks.CappValidator{
 			Client:  mgr.GetClient(),
 			Decoder: decoder,
 		}})
 
-		hookServer.Register(rcswebhooks.MutatorServingPath, &webhook.Admission{Handler: &rcswebhooks.CappMutator{
+		hookServer.Register("/mutate-capp", &webhook.Admission{Handler: &webhooks.CappMutator{
 			Client:  mgr.GetClient(),
 			Decoder: decoder,
 		}})

api/rcs/v1alpha1/groupversion_info.go

@@ -75,7 +75,7 @@ spec:
                       Claims lists the names of resources, defined in spec.resourceClaims,
                       that are used by this container.
 
-                      This is an alpha field and requires enabling the
+                      This field depends on the
                       DynamicResourceAllocation feature gate.
 
                       This field is immutable. It can only be set for containers.