-
Notifications
You must be signed in to change notification settings - Fork 142
First pass at Operations docs #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dabe420
to
78092bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small rendering change requested, otherwise looks good! Approving to not block
8118d1c
to
21bed19
Compare
Gonna hold on merging until crossplane/crossplane#6695 is merged, since this PR documents stuff in that one (namely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @negz! this is really useful content that will be very helpful for users learning about operations and developing them for their control planes 💪
Apply backticks to Kubernetes resource types (Operation, Ingress, ClusterRole, Job) to follow documentation style conventions for API objects per Jared's feedback in PR crossplane#956.
Add backticks to all status field names (Conditions, Succeeded, ValidPipeline, Failures, Pipeline) to match AppliedResourceRefs per Jared's feedback in PR crossplane#956.
b6a7d66
to
00b3296
Compare
Feels like it belongs here as a top-level tool, despite being alpha. Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
Add Test an operation section to Operations concept documentation showing how to preview Operations locally using the CLI. Follows same pattern as composition render documentation with usage examples and output format. Signed-off-by: Nic Cope <[email protected]>
…very Add critical guidance for WatchOperation functions that request resources dynamically. Functions must return consistent requirements across iterations for proper stabilization. Include working example with error handling. Signed-off-by: Nic Cope <[email protected]>
Change from plain code block to console with disabled line numbers and copy functionality per docs engineer feedback. Improves visual presentation of the cron schedule diagram. Signed-off-by: Nic Cope <[email protected]>
Change alphaVersion from 'v2.0-preview' to '2.0' to avoid double 'v' rendering in the documentation. Signed-off-by: Nic Cope <[email protected]>
Apply backticks to Kubernetes resource types (Operation, Ingress, ClusterRole, Job) to follow documentation style conventions for API objects per Jared's feedback in PR crossplane#956. Signed-off-by: Nic Cope <[email protected]>
Add backticks to all status field names (Conditions, Succeeded, ValidPipeline, Failures, Pipeline) to match AppliedResourceRefs per Jared's feedback in PR crossplane#956. Signed-off-by: Nic Cope <[email protected]>
Changed 'SSL Monitor Operation API' to 'SSL Monitor Operation' in the mermaid diagram to prevent text truncation that was showing as 'SSL Monitor Operation AP' in the rendered output. Signed-off-by: Nic Cope <[email protected]>
Sorted all dictionary files in utils/vale/styles/Crossplane/ alphabetically: - allowed-jargon.txt - brands.txt - crossplane-words.txt - provider-words.txt - spelling-exceptions.txt This removes duplicate entries and ensures consistent ordering for easier maintenance and Vale linting compliance. Signed-off-by: Nic Cope <[email protected]>
Added a new troubleshooting item to operation.md documenting the common error when Operations feature is not enabled and how to resolve it by adding the --enable-operations flag to Crossplane's startup arguments. Updated numbering for subsequent troubleshooting items accordingly. Signed-off-by: Nic Cope <[email protected]>
Updated status field names in operation.md to match actual YAML capitalization: conditions, failures, pipeline, appliedResourceRefs instead of the capitalized versions. Signed-off-by: Nic Cope <[email protected]>
Fixed Vale linter disable comment that was interrupting the ordered list in the "Event handling" section of watchoperation.md. Moved the Vale disable comments to wrap around the entire list instead of interrupting it, which resolves the ordering numbering reset issue. Signed-off-by: Nic Cope <[email protected]>
Added introductory sentence before Operations diagram to match the pattern used for other diagrams. Explains the SSL certificate monitoring scenario that the diagram illustrates, connecting the use case to the visual representation. Signed-off-by: Nic Cope <[email protected]>
First pass at Operations documentation including getting started guide and concept documentation.
I've tested the getting started guide end-to-end in a live cluster and it works perfectly. Here's what I validated:
Test Environment:
--enable-operations
)Test Results:
All steps in the getting started guide work as documented:
cert-monitor.crossplane.io/expires: Sep 29 08:34:02 2025 GMT
cert-monitor.crossplane.io/days-until-expiry: "53"
cert-monitor.crossplane.io/status: ok
SYNCED=True
andSUCCEEDED=True
with detailed outputThe key functionality works correctly: required resource fetching, SSL certificate inspection via Python, resource modification (adding annotations), and operation output for monitoring.
Dependencies
crossplane alpha render op
command (tested and working)