-
Notifications
You must be signed in to change notification settings - Fork 108
feat: improve iOS detected devices view #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
talaviram
wants to merge
2
commits into
capacitor-community:main
Choose a base branch
from
talaviram:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| import UIKit | ||
|
|
||
| class DeviceListView: UIViewController, UITableViewDelegate, UITableViewDataSource { | ||
|
|
||
| private let tableView = UITableView() | ||
| private let cancelButton = UIButton(type: .system) | ||
| private let titleLabel = UILabel() | ||
| private let progressIndication = UIActivityIndicatorView() | ||
| private var onCancel: (() -> Void)? | ||
| private var devices: [(name: String, action: () -> Void)] = [] | ||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| isModalInPresentation = true // don't allow drag to dismiss | ||
| setupUI() | ||
| addBlurBackground() | ||
| } | ||
|
|
||
| func setTitle(_ title: String?) { | ||
| titleLabel.text = title | ||
| } | ||
|
|
||
| func setCancelButton(_ title: String?, action: @escaping () -> Void) { | ||
| cancelButton.setTitle(title, for: .normal) | ||
| self.onCancel = action | ||
| } | ||
|
|
||
| func addItem(_ name: String, action: @escaping () -> Void) { | ||
| devices.append((name, action)) | ||
| tableView.reloadData() | ||
| } | ||
|
|
||
| private func addBlurBackground() { | ||
| let blurEffect = UIBlurEffect(style: .systemChromeMaterial) | ||
| let blurView = UIVisualEffectView(effect: blurEffect) | ||
| blurView.frame = view.bounds | ||
| blurView.autoresizingMask = [.flexibleWidth, .flexibleHeight] | ||
| view.insertSubview(blurView, at: 0) | ||
| } | ||
|
|
||
| private func setupUI() { | ||
| titleLabel.textAlignment = .center | ||
| titleLabel.font = UIFont.boldSystemFont(ofSize: 22) | ||
|
|
||
| let titleStack = UIStackView(arrangedSubviews: [titleLabel, progressIndication]) | ||
| titleStack.axis = .horizontal | ||
| titleStack.alignment = .center | ||
| titleStack.distribution = .fill | ||
| titleStack.spacing = 8 | ||
| titleStack.translatesAutoresizingMaskIntoConstraints = false | ||
| view.addSubview(titleStack) | ||
|
|
||
| progressIndication.translatesAutoresizingMaskIntoConstraints = false | ||
| progressIndication.startAnimating() | ||
| progressIndication.hidesWhenStopped = true | ||
| progressIndication.setContentHuggingPriority(.required, for: .horizontal) | ||
| NSLayoutConstraint.activate([ | ||
| progressIndication.widthAnchor.constraint(equalToConstant: 22), | ||
| progressIndication.heightAnchor.constraint(equalToConstant: 22) | ||
| ]) | ||
|
|
||
| tableView.backgroundColor = .clear | ||
| tableView.delegate = self | ||
| tableView.dataSource = self | ||
| tableView.translatesAutoresizingMaskIntoConstraints = false | ||
| tableView.register(UITableViewCell.self, forCellReuseIdentifier: "cell") | ||
| view.addSubview(tableView) | ||
|
|
||
| // Cancel Button | ||
| cancelButton.setTitleColor(.systemRed, for: .normal) | ||
| cancelButton.addTarget(self, action: #selector(dismissPopover), for: .touchUpInside) | ||
| cancelButton.translatesAutoresizingMaskIntoConstraints = false | ||
| view.addSubview(cancelButton) | ||
|
|
||
| NSLayoutConstraint.activate([ | ||
| titleStack.topAnchor.constraint(equalTo: view.topAnchor, constant: 10), | ||
| titleStack.leadingAnchor.constraint(equalTo: view.leadingAnchor, constant: 30), | ||
| titleStack.trailingAnchor.constraint(equalTo: view.trailingAnchor, constant: -30), | ||
| titleStack.heightAnchor.constraint(equalToConstant: 30), | ||
|
|
||
| // TableView | ||
| tableView.topAnchor.constraint(equalTo: titleLabel.bottomAnchor, constant: 10), | ||
| tableView.leadingAnchor.constraint(equalTo: view.leadingAnchor, constant: 10), | ||
| tableView.trailingAnchor.constraint(equalTo: view.trailingAnchor, constant: -10), | ||
| tableView.bottomAnchor.constraint(equalTo: cancelButton.topAnchor, constant: -10), | ||
|
|
||
| // Cancel Button at the Bottom | ||
| cancelButton.leadingAnchor.constraint(equalTo: view.leadingAnchor), | ||
| cancelButton.trailingAnchor.constraint(equalTo: view.trailingAnchor), | ||
| cancelButton.bottomAnchor.constraint(equalTo: view.bottomAnchor, constant: -10), | ||
| cancelButton.heightAnchor.constraint(equalToConstant: 40) | ||
| ]) | ||
| } | ||
|
|
||
| @objc private func dismissPopover() { | ||
| onCancel?() | ||
| dismiss(animated: true) | ||
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { | ||
| return devices.count | ||
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | ||
| let cell = tableView.dequeueReusableCell(withIdentifier: "cell", for: indexPath) | ||
| cell.textLabel?.text = devices[indexPath.row].name | ||
| cell.textLabel?.textColor = .systemBlue | ||
| cell.textLabel?.backgroundColor = .clear | ||
| cell.backgroundColor = .clear | ||
| cell.contentView.backgroundColor = .clear | ||
| cell.textLabel?.textAlignment = .center | ||
| cell.selectionStyle = .default | ||
| return cell | ||
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | ||
| tableView.deselectRow(at: indexPath, animated: true) | ||
| devices[indexPath.row].action() // Execute closure action | ||
| dismiss(animated: true) // Optionally close the popover | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action is never used here i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@talaviram any chance you've got some time to double-check this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry. been busy :)
@PAFriedrichMueller thank you for taking the time and discovering the missing call.
I've pushed a commit that can be squashed/fixup (so it'll be easier to review).
I've simply forgot to pass the action closure properly (oops).
Let me know if it's working as expected now.