feat: improve iOS detected devices view #767
Conversation
|
Thanks for taking the time to raise this! Interesting bug you've encountered here! I wish there was an easier way to workaround this... The new interface you've added here looks ok, but it has a lot of visual and behaviour differences compared to the version it replaces. Main things that stick out to me are:
Would you have the time to try and align it a little more closely with the UIAlertController it replaces? |
|
Ok, I've tried to make it feel more like a dialog for devices. Anyway, more blurry like iOS and on iOS 15+ I can easily make the view take less space. Hope this is closer to what you had in mind.
|
|
Sorry for bumping this, but I'd like to use the main branch for another project which I want to PR and this really improves experience on iOS. Thank you again. |
|
I shall endeavour to look at this soon @talaviram Apologies, time slipped away from me on this. |
| titleLabel.text = title | ||
| } | ||
|
|
||
| func setCancelButton(_ title: String?, action: @escaping () -> Void) { |
There was a problem hiding this comment.
action is never used here i think
There was a problem hiding this comment.
@talaviram any chance you've got some time to double-check this comment?
There was a problem hiding this comment.
Hey, sorry. been busy :)
@PAFriedrichMueller thank you for taking the time and discovering the missing call.
I've pushed a commit that can be squashed/fixup (so it'll be easier to review).
I've simply forgot to pass the action closure properly (oops).
Let me know if it's working as expected now.
prior to this, it used Alert view that could easily be cluttered when scanning without filters in a modern enviornment with > 10 devices. this now uses UIPopoverPresentationController and UITableView to allow scrollable list.
3 participants
This avoid overlapping / improved iOS device view.
Before this PR:
After: