Skip to content

Conversation

@TheRealFalcon
Copy link
Contributor

@TheRealFalcon TheRealFalcon commented Mar 19, 2025

Proposed Commit Message

chore: switch to has-signed-canonical-cla GH action

https://discourse.ubuntu.com/t/new-canonical-cla-process/55853

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions bot added the documentation This Pull Request changes documentation label Mar 19, 2025
@TheRealFalcon TheRealFalcon force-pushed the cla branch 2 times, most recently from 82ab1bc to 7eb97a3 Compare March 19, 2025 16:23
@TheRealFalcon TheRealFalcon changed the title WIP: chore: switch to has-signed-canonical-cla GH action chore: switch to has-signed-canonical-cla GH action Mar 19, 2025
If your company has signed the CLA for you, please contact us to help in
verifying which Launchpad/GitHub accounts are associated with the company.
`contributor license agreement <CLA_>`_ (CLA). A check is run against
every pull request to ensure that the CLA has been signed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealFalcon Shall we make a note that August 2025 may require renewing your CLA signing?

Copy link
Contributor Author

@TheRealFalcon TheRealFalcon Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that makes sense in our first PR documentation as the people signing now won't need to re-sign. I think we'll just need to address it individually as it comes up on a PR.

Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it will affect some existing users who have relied upon our tools/.github-cla-signers file but haven't yet renewed their CLA specifically at https://ubuntu.com/legal/contributors/agreement.

One can confirm whether they need to sign the CLA with:

url https://cla.canonical.com/cla/check?github_usernames=YOUR_GITHUB_USERNAME

I just went through the process of signing the CLA again, which looks like the following as an individual contributor:

Screenshot from 2025-03-19 12-37-44

And choosing your associated email address from the github account:
Screenshot from 2025-03-19 12-38-23

Once that was done, I can confirm I've renewed my CLA:

$ curl https://cla.canonical.com/cla/check?github_usernames=blackboxsw
{"emails":{},"github_usernames":{"blackboxsw":true},"launchpad_usernames":{}}

We should rebase #6097 when this lands as I think @a-dubs is one of those users that isn't in the cla.canonical.com service.

@TheRealFalcon TheRealFalcon merged commit 9e64882 into canonical:main Mar 19, 2025
21 checks passed
@TheRealFalcon TheRealFalcon deleted the cla branch March 19, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This Pull Request changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants