chore: switch to has-signed-canonical-cla GH action (#6109)

https://discourse.ubuntu.com/t/new-canonical-cla-process/55853

Author: TheRealFalcon

.github/workflows/cla.yml

@@ -3,47 +3,8 @@ name: CLA Check
 on: [pull_request]
 
 jobs:
-  cla-validate:
-
+  cla-check:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v1
-    - name: Check CLA signing status for ${{ github.event.pull_request.user.login }}
-      run: |
-        cat > unsigned-cla.txt <<EOF
-          Hello ${{ github.event.pull_request.user.login }},
-
-          Thank you for your contribution to cloud-init.
-
-          In order for us to merge this pull request, you need
-          to have signed the Contributor License Agreement (CLA).
-          Please sign the CLA by following our
-          contribution guide at:
-            https://docs.cloud-init.io/en/latest/development/first_PR.html
-
-          Thanks,
-          Your friendly cloud-init upstream
-        EOF
-
-        has_signed() {
-            username="$1"
-            grep -q ": \"$username\"" ./tools/.lp-to-git-user && return 0
-            grep -q "^$username$" ./tools/.github-cla-signers && return 0
-            return 1
-        }
-
-        if has_signed "${{ github.event.pull_request.user.login }}"; then
-            echo "Thanks ${{ github.event.pull_request.user.login }} for signing cloud-init's CLA"
-        else
-           cat unsigned-cla.txt
-           exit 1
-        fi
-
-  check-cla-signers:
-    name: Verify that ./tools/.github-cla-signers is in alphabetical order
-    runs-on: ubuntu-24.04
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Check CLA signers file
-        run: tools/check-cla-signers
+      - name: Check if CLA signed
+        uses: canonical/has-signed-canonical-cla@v2

doc/rtd/development/contribute_docs.rst

@@ -52,13 +52,6 @@ write any content.
 In your first PR
 =================
 
-You will need to add your GitHub username (alphabetically) to the in-repository
-list that we use to track :ref:`CLA signatures <contributing-prerequisites>`:
-`tools/.github-cla-signers`_.
-
-Please include this in the same PR alongside your first contribution. Do
-not create a separate PR to add your name to the CLA signatures.
-
 If you need some help with your contribution, you can contact us on our
 `IRC channel <IRC_>`_. If you have already submitted a work-in-progress PR, you
 can also ask for guidance from our technical author by `tagging s-makin`_ as a

doc/rtd/development/first_PR.rst

@@ -14,37 +14,14 @@ Sign the CLA
 ============
 
 To contribute to cloud-init, you must first sign the Canonical
-`contributor license agreement <CLA_>`_ (CLA).
-
-If you have already signed it as an individual, your Launchpad username will be
-listed in the `contributor-agreement-canonical`_ group. Unfortunately there is
-no easy way to check if the organisation or company you are working for has
-signed it.
-
-When you sign:
-
-* ensure that you fill in the GitHub username field,
-* when prompted for a 'Project contact' or 'Canonical Project Manager', enter
-  'James Falcon'.
-
-If your company has signed the CLA for you, please contact us to help in
-verifying which Launchpad/GitHub accounts are associated with the company.
+`contributor license agreement <CLA_>`_ (CLA). A check is run against
+every pull request to ensure that the CLA has been signed.
 
 For any questions or help with the process, email
 `James Falcon <mailto:[email protected]>`_ with the subject:
 "Cloud-init CLA". You can also contact user ``falcojr`` in the #cloud-init
 channel on the `Libera IRC network <IRC_>`_.
 
-Add your name to the CLA signers list
-=====================================
-
-As part of your first PR to cloud-init, you should also add your GitHub
-username (alphabetically) to the in-repository list that we use to track CLA
-signatures: `tools/.github-cla-signers`_.
-
-`PR #344`_ and `PR #345`_ are good examples of what this should look like in
-your pull request, though please do not use a separate PR for this step.
-
 Create a sandbox environment
 ============================
 
@@ -75,7 +52,5 @@ cloud-init :ref:`Code Review Process<code_review_process>`, so you can
 understand how your changes will end up in cloud-init's codebase.
 
 .. include:: ../links.txt
-.. _tools/.github-cla-signers: https://github.com/canonical/cloud-init/blob/main/tools/.github-cla-signers
-.. _contributor-agreement-canonical: https://launchpad.net/%7Econtributor-agreement-canonical/+members
 .. _PR #344: https://github.com/canonical/cloud-init/pull/344
 .. _PR #345: https://github.com/canonical/cloud-init/pull/345

doc/rtd/development/index.rst

@@ -57,8 +57,6 @@ Pull request checklist
 
 Before any pull request can be accepted, remember to do the following:
 
-* Make sure your GitHub username is added (alphabetically) to the in-repository
-  list that we use to track CLA signatures: `tools/.github-cla-signers`_.
 * Add or update any :ref:`unit tests<testing>` accordingly.
 * Add or update any :ref:`integration_tests` (if applicable).
 * Format code (using ``black`` and ``isort``) with ``tox -e do_format``.