Skip to content

FDR greater than 1.0 set to 1. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

iblacksand
Copy link
Collaborator

For FDR > 1, gsea will set the value back to 1.0. This copies the behavior from the original R package. Fixes #27.

@iblacksand iblacksand added bug Something isn't working library Deals with the library portion of the project Python Deals with the Python Package labels Apr 8, 2025
@iblacksand iblacksand self-assigned this Apr 8, 2025
@iblacksand iblacksand linked an issue Apr 8, 2025 that may be closed by this pull request
@iblacksand iblacksand merged commit 6f5f8fa into master Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working library Deals with the library portion of the project Python Deals with the Python Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FDR > 1 should not be possible
1 participant