Skip to content

FDR > 1 should not be possible #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iblacksand opened this issue Apr 8, 2025 · 0 comments · Fixed by #28
Closed

FDR > 1 should not be possible #27

iblacksand opened this issue Apr 8, 2025 · 0 comments · Fixed by #28
Assignees
Labels
bug Something isn't working library Deals with the library portion of the project Python Deals with the Python Package

Comments

@iblacksand
Copy link
Collaborator

From Google Group Post (https://groups.google.com/g/webgestalt/c/fynNrb4RMlQ):

Hi!

Today I have tried to use the webgestaltpy 0.3.1 for GSEA, and I was surprised to see that the reported FDR values exceed 1. What is going on there, is his expected? Should I do the adjustment myself?

I checked the github, and even in the script comments(https://github.com/bzhanglab/webgestaltpy/blob/master/src/lib.rs) example the FDR exceeds 1. I paste the script comment example below:

/// # Example
///
/// ```python
/// import webgestaltpy
///
/// res = webgestaltpy.gsea("kegg.gmt", "example_ranked_list.rnk")
///
/// print(res[0:2]) # print first two results
/// ```
///
/// **Output**
///
/// ```
/// [
///   {
///     'set': 'has00010',
///     'p': 0.353,
///     'fdr': 1.276048474073356,
///     'es': 0.40653028852961814,
///     'nes': 1.07659486501464,
///     'leading_edge': 24
///   },
///   {
///     'set': 'has00020',
///     'p': 0,
///     'fdr': 0.028834551777982824,
///     'es': 0.6216527702210619,
///     'nes': 1.5721004858071521,
///     'leading_edge': 20
///   }
/// ]
/// ```
@iblacksand iblacksand added bug Something isn't working library Deals with the library portion of the project Python Deals with the Python Package labels Apr 8, 2025
@iblacksand iblacksand linked a pull request Apr 8, 2025 that will close this issue
@iblacksand iblacksand self-assigned this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working library Deals with the library portion of the project Python Deals with the Python Package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant