Issue-356: Drop unnecessary Authorizer #364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibihim
changed the title
ibihim
force-pushed
the
ibihim/2025-03-13_issue-356_drop-or-not-to-drop-attrs
branch
2 times, most recently
from
0da710f to
640a6f0
Compare
|
@ibihim add log output before change, to show an exemplary resource attribute for that case. Make a (manual) test for what would happen, if you have a resource request. |
stlaz
added
the
sig-auth-acceptance
ibihim
changed the title
stlaz
requested changes
Apr 29, 2025
| } | ||
|
|
||
| delegated = append(delegated, staticAuthorizer) | ||
| authz = union.New(staticAuthorizer, authz) |
There was a problem hiding this comment.
This is an odd change. Can you please write full unit test coverage of the original code (so a unit tests commit comes first) and then start moving authorizers around?
ibihim
force-pushed
the
ibihim/2025-03-13_issue-356_drop-or-not-to-drop-attrs
branch
4 times, most recently
from
6aa5827 to
6e27005
Compare
Masking the resource attributes value to "just" path, verb and user is potentially suboptimal, as it ignores other fields that would be of interest for a SAR request. This use-case makes sense for regular HTTP request (non kubernetes resource request), but those kind of requests, don't populate the other fields in the resource attributes anyway. Is theoretically a regression, which we should keep in mind.
ibihim
force-pushed
the
ibihim/2025-03-13_issue-356_drop-or-not-to-drop-attrs
branch
from
6e27005 to
075d874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Notes
authorizer.Attributesintended? Why? #356