app: add unit tests for the authorizer setup #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
reviewed
May 26, 2025
stlaz
added
the
sig-auth-acceptance
ibihim
force-pushed
the
krp-sig-auth-acceptance-authz-unit-tests
branch
2 times, most recently
from
d53adc1 to
8a280a8
Compare
In particular it seems to be useful to verify the order of authorization as well.
ibihim
force-pushed
the
krp-sig-auth-acceptance-authz-unit-tests
branch
from
8a280a8 to
1c0f41f
Compare
stlaz
requested changes
May 28, 2025
stlaz
reviewed
Jun 2, 2025
|
LGTM, let's fix the CI and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add unit tests that verify the authorizers work as expected in appropriate order.
Why
I want to refactor that stuff 😄