Skip to content

knet_manager: do not try to set state for non-existing links #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

knet_manager: do not try to set state for non-existing links #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/netlink/knet_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,15 @@ bool knet_manager::portdev_removed(rtnl_link *link) {
* @return 0 on success
*/
int knet_manager::change_port_status(const std::string name, bool status) {
{
std::lock_guard<std::mutex> lock{tn_mutex};

if (port_names2id.find(name) == port_names2id.end()) {
VLOG(1) << __FUNCTION__ << ": unknown port " << name;
return -EINVAL;
}
}

std::ofstream file("/proc/bcm/knet/link");

if (file.is_open()) {
Expand All @@ -312,6 +321,15 @@ int knet_manager::change_port_status(const std::string name, bool status) {
*/
int knet_manager::set_port_speed(const std::string name, uint32_t speed,
uint8_t duplex) {
{
std::lock_guard<std::mutex> lock{tn_mutex};

if (port_names2id.find(name) == port_names2id.end()) {
VLOG(1) << __FUNCTION__ << ": unknown port " << name;
return -EINVAL;
}
}

std::ofstream file("/proc/bcm/knet/link");

if (file.is_open()) {
Expand Down