knet_manager: do not try to set state for non-existing links #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OF-DPA brings all links up at boot, there is a chance that the is a link state change before we received the port table and created the ports. If this happens, then we get a change modification for speed/link, but there is no link to modify. This is harmless since we will set the link to down once we do create the port interface, but triggers a warning from knet on startup: kernel: linux-bcm-knet (1197): Warning: unknown network interface: 'port1' kernel: linux-bcm-knet (1197): Warning: unknown network interface: 'port2' ... kernel: linux-bcm-knet (1197): Warning: unknown network interface: 'port54' So check if the link is created before trying to update its state. Fixes: 40f68c8 ("add knet manager for using knet based interfaces") Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_knet_avoid_error_knet
branch
from
1ab3983 to
cefce26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OF-DPA brings all links up at boot, there is a chance that the is a link state change before we received the port table and created the ports.
If this happens, then we get a change modification for speed/link, but there is no link to modify. This is harmless since we will set the link to down once we do create the port interface, but triggers a warning from knet on startup:
So check if the link is created before trying to update its state.
Fixes: 40f68c8 ("add knet manager for using knet based interfaces")