-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/add new form to dm view #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cappel89
wants to merge
67
commits into
pre_release_v3
Choose a base branch
from
feat/add_new_form_to_dm_view
base: pre_release_v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
34b2800
feat(bec_widget): save screenshot to bytes
wyzula-jan 4bc36eb
fix(widget_state_manager): added shiboken check
wyzula-jan 17b0d60
fix(dark_mode_button): skip settings added
wyzula-jan 33942a6
fix(main_window): cleanup adjusted with shiboken6
wyzula-jan 8b8edd4
feat(advanced_dock_area): UI/UX for profile management improved, savi…
wyzula-jan e6ca82f
fix(advanced_dock_area): disable developer mode switch
wyzula-jan e8eb1c0
fix(main_window): removed general forced cleanup
wyzula-jan b74f5b6
feat(advanced_dock_area): created DockAreaWidget base class; profile …
wyzula-jan cfdb859
refactor(monaco_dock): changed to use DockAreaWidget
wyzula-jan 991cb01
refactor(developer_view): changed to use DockAreaWidget
wyzula-jan b170ab0
refactor(main_app): adapted for DockAreaWidget changes
wyzula-jan 9802540
fix(widget_state_manager): visible is always true
wyzula-jan 8a741e0
fix(ide_explorer): light mode fixed
wyzula-jan 0176204
fix(qt_ads): pythons stubs match structure of PySide6QtAds
wyzula-jan 9905b49
fix(widget_io): find ancestor returns correct type
wyzula-jan 7fc2976
fix(bec_widget): improved qt enums; grab safeguard
wyzula-jan 5a64bf2
fix(client): client regenerated
wyzula-jan 07d84d9
fix(widget_state_manager): always setting visible to true
wyzula-jan feeb20f
feat(widget_state_manager): can serialize from root
wyzula-jan 06eb417
fix(widget_state_manager): skip property listed introduced
wyzula-jan 6be0da6
fix(widget_state_manager): IDEExplorer plugin not initialised in desi…
wyzula-jan a75651e
fix(widgets): removed isVisible from all SafeProperties
wyzula-jan d181537
feat(advanced_dock_area): instance lock for multiple ads in same session
wyzula-jan 53ece6c
fix(widget_state_manager): visibility managed by parent
wyzula-jan 3dc376e
WIP removed for device manager
wyzula-jan b9056f6
refactor(device-manager-view): update view to bec_widgets.QtAds
cappel89 382287b
feat(device-config-template): add device config template widget
cappel89 1cde79c
refactor(device-manager-view): add config form dialog to DM view
cappel89 8d1eb22
refactor(dm-ophyd-test): Refactor dm-ophyd-test; Add Config and Conne…
cappel89 53c5a8b
fix(dm-ophyd-test): refactor device-table-view and dm-view
cappel89 48a55b5
wip show legend until legend solution is discussed
cappel89 fc1048a
wip minor improvements
cappel89 618cc78
wip tests
cappel89 5fe3738
refactor(device-manager-view): Add enable/disable of upload to redis …
cappel89 2b686aa
wip add cleanup logic for OphydDeviceTest implemented as a Dialog
cappel89 3ef7e1d
wip improve performance for redis compar...
cappel89 8025bcc
wip add enable action to update redis
cappel89 438f35a
drop camelCase in header names
cappel89 744c098
refactor(device-manager-view): add upload_redis_dialog, cleanup, fix …
cappel89 9a6f79e
wip
cappel89 ff678d9
refactor(device-manager-view): cleanup and bugfixes
cappel89 c5149ac
refactor(dm-config-view): cleanup and tests
cappel89 eecbd46
wip refactor to DeviceTable
cappel89 7c1a318
wip fix table sorting
cappel89 e1614bc
feat(bec-list): Add wrapper around QListWidget with simplified API
cappel89 4fe66db
refactor(ophyd-test): refactor ophyd test widget
cappel89 bc333d4
wip delete ophyd_test
cappel89 3398780
wip save state
cappel89 c8744f4
wip tests
cappel89 496647f
wip improvements of the code, remove ghost item
cappel89 740707c
wip
cappel89 b4dabfa
wip fix tests
cappel89 6eca765
wip
cappel89 1f1eddc
fix(conftest): make SafeSlot raise per default in unit tests
cappel89 8d0ff76
wip fix tests
cappel89 44cb230
refactor(table): move away from custom widgets in table, checkable, t…
cappel89 c66b211
wip
cappel89 67a8a52
wip test coverage
cappel89 3c4f0e8
wip
cappel89 9aa014c
wip set RPC=False for all widgets of dm view
cappel89 3eb879e
test(bec-list): add tests for beclist widget
cappel89 9754df0
wip cleanup
cappel89 00d4c40
WIP client regenerated
wyzula-jan e4fa406
wip import optimised
wyzula-jan b15d883
wip fix yaml_load wrong import
wyzula-jan f43709b
wip device_manager_view migrated to new DockAreaWidget
wyzula-jan f9645f5
wip splitter logic removed from view
wyzula-jan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
bec_widgets/applications/views/device_manager_view/device_manager_dialogs/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| from .config_choice_dialog import ConfigChoiceDialog | ||
| from .device_form_dialog import DeviceFormDialog |
49 changes: 49 additions & 0 deletions
49
...ets/applications/views/device_manager_view/device_manager_dialogs/config_choice_dialog.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Dialog to chgoose config loading method: replace, add or cancel.""" | ||
|
|
||
| from enum import IntEnum | ||
|
|
||
| from qtpy.QtWidgets import QDialog, QDialogButtonBox, QLabel, QSizePolicy, QVBoxLayout | ||
|
|
||
cappel89 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| class ConfigChoiceDialog(QDialog): | ||
| class Result(IntEnum): | ||
| CANCEL = QDialog.Rejected | ||
| ADD = 2 | ||
| REPLACE = 3 | ||
|
|
||
| def __init__( | ||
| self, | ||
| parent=None, | ||
| custom_label: str = "Do you want to replace the current config or add to it?", | ||
| ): | ||
| super().__init__(parent) | ||
| self.setWindowTitle("Load Config") | ||
|
|
||
| layout = QVBoxLayout(self) | ||
|
|
||
| label = QLabel(custom_label) | ||
| label.setWordWrap(True) | ||
| layout.addWidget(label) | ||
|
|
||
| # Use QDialogButtonBox for native layout | ||
| self.button_box = QDialogButtonBox(self) | ||
| self.cancel_btn = self.button_box.addButton( | ||
| "Cancel", QDialogButtonBox.ButtonRole.ActionRole # RejectRole will be next to Accept... | ||
| ) | ||
| self.replace_btn = self.button_box.addButton( | ||
| "Replace", QDialogButtonBox.ButtonRole.AcceptRole | ||
| ) | ||
| self.add_btn = self.button_box.addButton("Add", QDialogButtonBox.ButtonRole.AcceptRole) | ||
|
|
||
| layout.addWidget(self.button_box) | ||
|
|
||
| for btn in [self.replace_btn, self.add_btn, self.cancel_btn]: | ||
| btn.setMinimumWidth(80) | ||
| btn.setSizePolicy(QSizePolicy.Expanding, QSizePolicy.Preferred) | ||
|
|
||
| # Connections using native done(int) | ||
| self.replace_btn.clicked.connect(lambda: self.done(self.Result.REPLACE)) | ||
| self.add_btn.clicked.connect(lambda: self.done(self.Result.ADD)) | ||
| self.cancel_btn.clicked.connect(lambda: self.done(self.Result.CANCEL)) | ||
|
|
||
| self.replace_btn.setFocus() | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.