Feat/add new form to dm view

[cappel89]

Description

This PR refactored and improved the device-manager view. The following things were addressed:

• Wrote a bespoke DeviceForm to add new devices based on templates (EpicsMotor, EpicsSignal, ...) to the device manager view. The widget is embedded in form of a dialog, and hooked up to all functionality. It also allows testing the device validity and connection.

• Refactoring of DMOphydTest widget. Although in theory working, there were a few issues with the widget, and also the test mechanism itself. The following factors were improved:
  I. Validation is tested for two stages. ConfigStatus and ConnectionStatus. This represents if the static-ophyd-test is started with "connect".
  II. Results of the static-ophyd-test are split into the above mentioned status stages. This is needed to differentiate between, my config is in principle okay, but I can't connect to the device right now.

• All refactored widgets are combined together in the view, and are ready for testing. I attach below a snapshot how the arrangement of individual docks makes sense to me as these ratios are not yet set up in the view.

• TODO, consider creating a legend for icons in the Toolbar. I was running a bit out of time, and would also like to receive some input first.

• Tests need to be reviewed, and extended for the OphydTest widget.

• Add e2e tests

• Wait for feeedback @wyzula-jan @d-perl : If time allows, please test the functionality in depth. if possible use the widget and play a bit around. Try to break it :)

Note: Depending on the amount of feedback, I think that I could wrap up tests and feedback within a day, with exception of e2e test.

Related Issues

closes #886
closes #887
closes #885
closes #884
closes #883
closes #882
closes #839

Definition of Done

• Documentation is up-to-date.

[wakonig]

a quick first round ;)

[wyzula-jan]

If you delete all devices and try to upload the validation hangs forever:

Screen.Recording.2025-10-30.at.10.33.54.mov

[wyzula-jan]

I would switch replace and cancel, the similar approach could be used for all other dialogs

Check for example this article about MS/Apple/Google UX guidelines

[wyzula-jan]

If I click on validate connection and nothing is selected I would expect that the validation will be submitted for all devices. The current logic submits only selected field in the table:

Screen.Recording.2025-10-30.at.10.47.20.mov

[wyzula-jan]

There is something strange happening if I try to revalidate already validated device. In GroupBox Completed Validation there are some ghost items appearing if I smash the validate button multiple times.

I also think that user should be able to rerun validation on already validated device in case that idk it was unplugged accidentally etc. (maybe with some dialog such as "Do you want to run validation again on already validated devices?"). Current implementation just do something but do not inform user what is actually happening. If validation should not be available than I would add dialog or disable button completely.

Screen.Recording.2025-10-30.at.11.17.30.mov

[wyzula-jan]

I have an invalid device none, if I click on the toolbar action it tries to validate and I can try multiple times. If I try to do the same through the upload dialog nothing seems to happen.

Screen.Recording.2025-10-30.at.13.04.30.mov

[wyzula-jan]

scrollbar in the upload dialog has wrong render area:

Screen.Recording.2025-10-30.at.13.07.36.mov

[wyzula-jan]

upload do not change config it there is at least one device which is not validated. Here I had in my config bpm3a, then I removed it from gui and uploaded to redis. I got warning which I accepted but nothing is actually uploaded to redis. If this is intended behaviour then user should be notified that the upload didn't went through.

Screen.Recording.2025-10-30.at.13.11.18.mov

[wyzula-jan]

please use material icons instead of default qt icons for these 2 buttons in the dialog

[wakonig]

@cappel89 I just played around with it a bit and noticed that the device tags are not working when opening the device form: Existing tags are not shown and upon saving, there is a None added as well.

[wakonig]

you can safely remove the set_splitter_weights function. If necessary, it is already in view.py

[codecov]

Codecov Report

❌ Patch coverage is 59.57150% with 1736 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...s/device_config_template/device_config_template.py	9.90%	281 Missing and 1 partial ⚠️
...view/device_manager_dialogs/upload_redis_dialog.py	15.65%	264 Missing ⚠️
...omponents/device_config_template/template_items.py	21.61%	214 Missing ⚠️
...device_manager/components/ophyd_test/ophyd_test.py	59.83%	133 Missing and 12 partials ⚠️
..._view/device_manager_dialogs/device_form_dialog.py	20.11%	135 Missing ⚠️
...s/containers/advanced_dock_area/basic_dock_area.py	70.90%	86 Missing and 49 partials ⚠️
...ce_manager/components/device_table/device_table.py	73.75%	112 Missing and 20 partials ⚠️
...s/views/device_manager_view/device_manager_view.py	34.00%	99 Missing ⚠️
...ets/containers/advanced_dock_area/profile_utils.py	76.13%	58 Missing and 26 partials ⚠️
...ontainers/advanced_dock_area/advanced_dock_area.py	76.97%	32 Missing and 35 partials ⚠️
... and 21 more

📢 Thoughts on this report? Let us know!

[d-perl]

• in the device config dialog form, I think it's a bit confusing to show the device class when it's already selected at the top, I would hide this field and only show it for the custom device

• column headings are not nicely formatted / correct width, and the checkboxes are not centred (on linux)

• Default size of the config dialog could be a bit bigger