Add [email protected] #6018
Add [email protected] #6018
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (sourcekit_bazel_bsp) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the new module sourcekit_bazel_bsp at version 0.2.0. The submission is well-formed and adheres to the Bazel Central Registry policies. However, there is one issue in the presubmit.yml file where the build target is specified with an incorrect path, which would cause the presubmit checks to fail. The fix is provided in the detailed comment.
rockbruno
force-pushed
the
rochab/skbsp
branch
2 times, most recently
from
91f8640 to
a8a1f41
Compare
rockbruno
force-pushed
the
rochab/skbsp
branch
from
a8a1f41 to
bab5540
Compare
meteorcloudy
added
the
presubmit-auto-run
Head branch was pushed to by a user without write access
bazel-io
dismissed
meteorcloudy’s stale review
Require module maintainers' approval for newly pushed changes.
| platform: ${{ platform }} | ||
| bazel: ${{ bazel }} | ||
| build_flags: | ||
| - "--nobuild" # Remove this once the CI supports Xcode 26 |
There was a problem hiding this comment.
@fweikert Can we add Xcode 26 for our CI?
There was a problem hiding this comment.
@meteorcloudy Tried it again but seems it still isn't installed :( Would it be an issue for us to go forward with the nobuild solution in the meantime?
There was a problem hiding this comment.
Xcode 26 is installed on macos_arm64 but not for the intel platform macos, are you fine with just removing macos?
There was a problem hiding this comment.
Yes, it's not an issue. It's green now, thanks for the help!
rockbruno
force-pushed
the
rochab/skbsp
branch
from
713da63 to
3092e58
Compare
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (sourcekit_bazel_bsp) have been updated in this PR. |
3 participants
No description provided.