Skip to content

Conversation

@maxwellE
Copy link
Contributor

Adds this new module to the BCR

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (sourcekit_bazel_bsp) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Collaborator

@kotlaja kotlaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add github_user_id and github to the maintainer info?

@kotlaja kotlaja added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Aug 25, 2025
@bazel-io
Copy link
Member

bazel-io commented Sep 4, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (sourcekit_bazel_bsp) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@maxwellE maxwellE requested a review from kotlaja September 4, 2025 15:56
Adds this new module to the BCR

Signed-off-by: Maxwell Elliott <[email protected]>
Signed-off-by: Maxwell Elliott <[email protected]>
Signed-off-by: Maxwell Elliott <[email protected]>
Signed-off-by: Maxwell Elliott <[email protected]>
Signed-off-by: Maxwell Elliott <[email protected]>
Signed-off-by: Maxwell Elliott <[email protected]>
Signed-off-by: Maxwell Elliott <[email protected]>
@maxwellE maxwellE force-pushed the maxwelle/add-bazel-sourcekit-lsp branch from 63325b2 to 93ff602 Compare September 5, 2025 12:40
Signed-off-by: Maxwell Elliott <[email protected]>
@bkolb
Copy link

bkolb commented Sep 15, 2025

Is there anything left to do for this PR? It would be great to have that usable for the registry

@maxwellE
Copy link
Contributor Author

Is there anything left to do for this PR? It would be great to have that usable for the registry

This is blocked until the macOS executors can resolve this issue error: 'sourcekit_bazel_bsp~': package 'sourcekit_bazel_bsp~' is using Swift tools version 6.1.0 but the installed version is 6.0.3

We need a newer version of the Swift Toolchain to use this module.

@maxwellE
Copy link
Contributor Author

@kotlaja Is there a timeline for supporting the Swift 6.1.0 toolchain on the macos agents?

@meteorcloudy
Copy link
Member

meteorcloudy commented Sep 15, 2025

@maxwellE Can you try to install it with shell_commands in presubmit.yml file?

@rockbruno
Copy link
Contributor

Opened a new PR with the newest version here, will define a no-op target if it doesn't have Xcode 26 installed similarly to what I've seen has been done to other swift modules in the past.
#6018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants