Skip to content

Bump rules_jvm_external to 6.8 and switch resolver #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump rules_jvm_external to 6.8 and switch resolver #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ bazel_dep(name = "protobuf", version = "29.1", repo_name = "com_google_protobuf"
bazel_dep(name = "rules_cc", version = "0.1.1")
bazel_dep(name = "rules_go", version = "0.52.0")
bazel_dep(name = "rules_java", version = "8.5.1")
bazel_dep(name = "rules_jvm_external", version = "6.7")
bazel_dep(name = "rules_jvm_external", version = "6.8")
bazel_dep(name = "rules_proto", version = "7.0.2")
bazel_dep(name = "aspect_bazel_lib", version = "1.42.3")

Expand Down Expand Up @@ -143,7 +143,6 @@ maven.install(
fail_if_repin_required = True,
generate_compat_repositories = True,
lock_file = "//:contrib_rules_jvm_deps_install.json",
resolver = "maven",
Copy link
Collaborator

@gibfahn gibfahn Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to be clear, this switches us back to coursier as the resolver right?

Copy link
Collaborator Author

@shs96c shs96c Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, back to coursier now that it supports boms

strict_visibility = False,
)

Expand Down
Loading
Loading