Bump rules_jvm_external to 6.8 and switch resolver
#365
Conversation
With this release, the default resolver can handle BOM files. It's a better choice for us, since the maven dependency resolution mechanism isn't great. Returning to the default resolver is a better choice for us.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @shs96c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the rules_jvm_external version and switches the dependency resolver to leverage its improved BOM file handling, streamlining dependency management.
Highlights
- Dependency Management Upgrade: The rules_jvm_external Bazel rule has been updated from version 6.7 to 6.8.
- Resolver Switch: The dependency resolution mechanism has been changed from the explicit "maven" resolver to the new default resolver, which offers better handling of BOM (Bill of Materials) files.
- Transitive Dependency Updates: Numerous transitive dependencies have been updated to newer versions, and a new conflict resolution section has been introduced in the lock file to manage these updates.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully updates rules_jvm_external to version 6.8 and switches to the new default resolver. This is a significant improvement, as it resolves previously skipped dependencies and updates many artifacts to their latest versions, as seen in the regenerated lock file. The changes in MODULE.bazel are correct and align with the goal of leveraging the new resolver's capabilities. Overall, this is a solid and beneficial update for the project's dependency management.
| fail_if_repin_required = True, | ||
| generate_compat_repositories = True, | ||
| lock_file = "//:contrib_rules_jvm_deps_install.json", | ||
| resolver = "maven", |
There was a problem hiding this comment.
So to be clear, this switches us back to coursier as the resolver right?
There was a problem hiding this comment.
Yes, back to coursier now that it supports boms
2 participants
With this release, the default resolver can handle BOM files. It's a better choice for us, since the maven dependency resolution mechanism isn't great.